pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

TEP-0154: Enable concise resolver syntax - stage 1

Open chitrangpatel opened this issue 1 year ago • 57 comments

This PR enables concise resolver syntax as per TEP 0154. It allows users to pass a url like string to Taskref/name field.

This PR does not add the schemes supported by the built-in resolvers. That will come in followup PRs. Here, we just set up the framework.

Changes

  • Added Feature Flag: enable-concise-resolver-syntax
  • Updated validation logic for name such that it can also be url-like. Both name and params cannot be passed at the same time as discussed in the TEP. If using a url-like name then the feature flag must be enabled.
  • Resolution Request CRD now contains a new field url which is passed in the spec with params.
  • Enable param substitution in name like we allow in resolver params.
  • Updated Remote Resolution Interface to Handle ValidatingUrl.
  • Added ValidatingUrl to all built-in resolvers. Currently it does not validate anything. The details will be added in a followup PR.
  • Updated demo resolver and how-to-write-a-resolver docs.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [x] Has Tests included if any functionality added or changed
  • [x] pre-commit Passed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

TEP-0154: Enable concise resolver syntax

/kind feature /hold wait for TEP to be merged.

chitrangpatel avatar Apr 05 '24 15:04 chitrangpatel

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/container_validation.go 100.0% 96.4% -3.6
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 92.3% -7.7
pkg/apis/pipeline/v1/taskref_validation.go 100.0% 96.2% -3.8
pkg/reconciler/taskrun/taskrun.go 87.2% 86.4% -0.8
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3
pkg/resolution/resource/request.go 100.0% 80.0% -20.0

tekton-robot avatar Apr 05 '24 15:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/container_validation.go 100.0% 96.4% -3.6
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 92.3% -7.7
pkg/apis/pipeline/v1/taskref_validation.go 100.0% 96.2% -3.8
pkg/reconciler/taskrun/taskrun.go 87.2% 86.4% -0.8
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3
pkg/resolution/resource/request.go 100.0% 80.0% -20.0

tekton-robot avatar Apr 05 '24 15:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/container_validation.go 100.0% 96.4% -3.6
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 92.3% -7.7
pkg/apis/pipeline/v1/taskref_validation.go 100.0% 96.2% -3.8
pkg/reconciler/taskrun/taskrun.go 87.2% 86.4% -0.8
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3
pkg/resolution/resource/request.go 100.0% 80.0% -20.0

tekton-robot avatar Apr 05 '24 16:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/taskrun/taskrun.go 87.2% 86.4% -0.8
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3
pkg/resolution/resource/request.go 100.0% 80.0% -20.0

tekton-robot avatar Apr 05 '24 16:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/taskrun/taskrun.go 87.2% 86.4% -0.8
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 05 '24 16:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/taskrun/taskrun.go 87.2% 86.4% -0.8
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 05 '24 16:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.6% 0.1
pkg/reconciler/taskrun/taskrun.go 87.2% 86.4% -0.8
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 05 '24 17:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.6% 0.1
pkg/reconciler/taskrun/taskrun.go 87.2% 86.4% -0.8
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 05 '24 17:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 05 '24 20:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 05 '24 20:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 05 '24 21:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 05 '24 21:04 tekton-robot

/hold cancel

chitrangpatel avatar Apr 05 '24 22:04 chitrangpatel

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 13:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 13:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 65.0% -10.0
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 87.2% -4.7
pkg/resolution/resolver/framework/reconciler.go 73.1% 69.4% -3.7
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 13:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 66.7% -8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 91.1% -0.8
pkg/resolution/resolver/framework/reconciler.go 73.1% 75.0% 1.9
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 18:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 66.7% -8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 91.1% -0.8
pkg/resolution/resolver/framework/reconciler.go 73.1% 75.0% 1.9
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 18:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 66.7% -8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 97.8% 5.9
pkg/resolution/resolver/framework/reconciler.go 73.1% 77.8% 4.6
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 18:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 66.7% -8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 97.8% 5.9
pkg/resolution/resolver/framework/reconciler.go 73.1% 77.8% 4.6
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 18:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 83.3% 8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 97.8% 5.9
pkg/resolution/resolver/framework/reconciler.go 73.1% 77.8% 4.6
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 18:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 83.3% 8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/apis/pipeline/v1/pipelineref_validation.go 100.0% 95.5% -4.5
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 97.8% 5.9
pkg/resolution/resolver/framework/reconciler.go 73.1% 77.8% 4.6
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 19:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 83.3% 8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 97.8% 5.9
pkg/resolution/resolver/framework/reconciler.go 73.1% 77.8% 4.6
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 19:04 tekton-robot

@tektoncd/core-collaborators PTAL 🙏 It's ready for review.

chitrangpatel avatar Apr 08 '24 19:04 chitrangpatel

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 83.3% 8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 97.8% 5.9
pkg/resolution/resolver/framework/reconciler.go 73.1% 77.8% 4.6
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 08 '24 19:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 83.3% 8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 97.8% 5.9
pkg/resolution/resolver/framework/reconciler.go 73.1% 77.8% 4.6
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 10 '24 03:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 83.3% 8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 97.8% 5.9
pkg/resolution/resolver/framework/reconciler.go 73.1% 77.8% 4.6
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 10 '24 03:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 83.3% 8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 97.8% 5.9
pkg/resolution/resolver/framework/reconciler.go 73.1% 77.8% 4.6
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 10 '24 18:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
docs/resolver-template/cmd/demoresolver/main.go 75.0% 83.3% 8.3
pkg/apis/config/feature_flags.go 94.8% 94.9% 0.1
pkg/reconciler/pipelinerun/resources/apply.go 98.5% 97.9% -0.7
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.2% 93.8% 0.6
pkg/reconciler/taskrun/resources/taskref.go 92.6% 92.9% 0.3
pkg/resolution/resolver/bundle/resolver.go 96.3% 92.9% -3.4
pkg/resolution/resolver/cluster/resolver.go 83.3% 82.5% -0.8
pkg/resolution/resolver/framework/fakeresolver.go 91.9% 97.8% 5.9
pkg/resolution/resolver/framework/reconciler.go 73.1% 77.8% 4.6
pkg/resolution/resolver/git/resolver.go 85.2% 84.8% -0.4
pkg/resolution/resolver/http/resolver.go 92.4% 91.5% -0.9
pkg/resolution/resolver/hub/resolver.go 77.2% 76.7% -0.5
pkg/resolution/resource/name.go 76.2% 73.9% -2.3

tekton-robot avatar Apr 10 '24 18:04 tekton-robot

/assign @wlynch @vdemeester

chitrangpatel avatar Apr 11 '24 14:04 chitrangpatel