pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

Fix reason of PipelineRun status for PipelineRun having tasks timeout

Open pratap0007 opened this issue 1 year ago • 18 comments

This patch fixes to set the reason of PipelineRun status to PipelineRunTimeout if the tasks of a PipelineRun timeout because of the timeout.tasks parameter

Fixes: #7573

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [x] Has Tests included if any functionality added or changed
  • [ ] pre-commit Passed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

 Set the reason of PipelineRun status to PipelineRunTimeout if the tasks of a PipelineRun is timeout

pratap0007 avatar Mar 07 '24 17:03 pratap0007

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.6% 0.0

tekton-robot avatar Mar 07 '24 17:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.6% 0.0

tekton-robot avatar Mar 07 '24 17:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.6% 0.0

tekton-robot avatar Mar 07 '24 17:03 tekton-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from jeromeju after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Apr 05 '24 05:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

tekton-robot avatar Apr 05 '24 05:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

tekton-robot avatar Apr 05 '24 05:04 tekton-robot

Hi @pratap0007 are you actively working on this or shall we update the test results and close this one?

JeromeJu avatar Apr 10 '24 19:04 JeromeJu

Hi @pratap0007 are you actively working on this or shall we update the test results and close this one?

Hi @JeromeJu, I am looking to fix the test soon

pratap0007 avatar Apr 16 '24 05:04 pratap0007

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

tekton-robot avatar Apr 16 '24 07:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

tekton-robot avatar Apr 16 '24 07:04 tekton-robot

/retest

vdemeester avatar Jun 17 '24 15:06 vdemeester

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

tekton-robot avatar Jun 18 '24 04:06 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

tekton-robot avatar Jun 18 '24 04:06 tekton-robot

/retest

vdemeester avatar Jul 03 '24 09:07 vdemeester

@pritidesai I think this was last worked on in April so until someone picks it up again, I think we can remove it from the milestones.

@pratap0007 please let us know otherwise.

chitrangpatel avatar Jul 16 '24 16:07 chitrangpatel

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

tekton-robot avatar Aug 05 '24 06:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

tekton-robot avatar Aug 05 '24 06:08 tekton-robot

@pratap0007: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-integration-tests 778688d36ff8442566979e21e37353da84cc8775 link true /test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-beta-integration-tests 778688d36ff8442566979e21e37353da84cc8775 link true /test pull-tekton-pipeline-beta-integration-tests
pull-tekton-pipeline-alpha-integration-tests 778688d36ff8442566979e21e37353da84cc8775 link true /test pull-tekton-pipeline-alpha-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tekton-robot avatar Aug 05 '24 06:08 tekton-robot