if timeout.tasks is reached pipeline status.reason should be PipelineRunTimeout

[flokain]

Expected Behavior

if the tasks of a pipelineRun time out because of the timeout.tasks parameter, the reason for the PipelinRun satus should be PipelineRunTimeout.

Actual Behavior

status reason is Failed.

Steps to Reproduce the Problem

1. have pipeline that has a sleep for ever task
2. configure a pipelinrun and set timeout.tasks = "1m"
3. inspect pipelinerun status = false, reason=failed.

Additional Info

• Kubernetes version:

  Output of kubectl version:

Client Version: v1.25.3
Kustomize Version: v4.5.7
Server Version: v1.25.16-eks-8cb36c9

• Tekton Pipeline version:

  Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Client version: 0.31.2
Chains version: v0.16.0
Pipeline version: v0.47.5
Triggers version: v0.24.0
Dashboard version: v0.35.0

[vdemeester]

I do think it make sense (if any Task fails due to Timeout, to mark the PipelineRun has failed due to Timeout). cc @tektoncd/core-maintainers

[JeromeJu]

I do think it make sense (if any Task fails due to Timeout, to mark the PipelineRun has failed due to Timeout). cc @tektoncd/core-maintainers

Yes, this would be similar to what TaskRun has for timeout behaviour.

And just double checking if there is gonna be any concern with the change cc @AlanGreene 🤔

[AlanGreene]

No concerns from the Dashboard's perspective

[pratap0007]

/assign