pipeline
pipeline copied to clipboard
tektoncd
Migrate jaeger to otel API
Changes
OpenTelemetry has deprecated the use of jaeger exporter directly and it has been removed from the library since 1.20 (changelog)
This PR migrates the code to make it compatible with the recommended oltptracehttp exporter instead. Also fixes issues with broken imports when upgrading to otel 1.21
Fixes https://github.com/tektoncd/pipeline/issues/7464
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
- [ ] Has Tests included if any functionality added or changed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
NONE
Hi @kmjayadeep. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/tracing/tracing.go | 77.2% | 78.3% | 1.1 |
@vdemeester: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
-
/test pull-tekton-pipeline-alpha-integration-tests -
/test pull-tekton-pipeline-beta-integration-tests -
/test pull-tekton-pipeline-build-tests -
/test pull-tekton-pipeline-integration-tests -
/test pull-tekton-pipeline-unit-tests
The following commands are available to trigger optional jobs:
-
/test pull-tekton-pipeline-go-coverage
Use /test all to run all jobs.
In response to this:
/test pull-tekton-pipeline-go-coverage-df
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/tracing/tracing.go | 77.2% | 78.3% | 1.1 |
@kmjayadeep Could you please rebase this PR, so we merge it in time for v0.58?
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/tracing/tracing.go | 77.2% | 78.3% | 1.1 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/tracing/tracing.go | 77.2% | 78.3% | 1.1 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: afrittoli
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [afrittoli]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The following Tekton test failed:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-tekton-pipeline-go-coverage-df | 987aa1555677d392efda99a332879da9e40adf66 | link | true | /test pull-tekton-pipeline-go-coverage-df |
@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
-
/test pull-tekton-pipeline-alpha-integration-tests -
/test pull-tekton-pipeline-beta-integration-tests -
/test pull-tekton-pipeline-build-tests -
/test pull-tekton-pipeline-integration-tests -
/test pull-tekton-pipeline-unit-tests
The following commands are available to trigger optional jobs:
-
/test pull-tekton-pipeline-go-coverage
Use /test all to run all jobs.
In response to this:
/test pull-tekton-pipeline-go-coverage-df
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Not sure why the test is failing. Seems like a glitch. It is unable to run the second Task I think: https://dashboard.dogfooding.tekton.dev/#/namespaces/tekton-ci/pipelineruns/run-go-coverage-hswz7?pipelineTask=split-full-repo-name&step=split-name
I wonder if closing and reopening the PR will help her 🤔 ?
@chitrangpatel I have raised an identical PR in https://github.com/tektoncd/pipeline/pull/7748. Please feel free to close this one if that one gets through