pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

Published 20 hours ago • verified publisher icon tektoncd

TEP-0127: Larger Results via Sidecar Logs [Feedback Requested]

Open jerop opened this issue 2 years ago • 4 comments

In TEP-0127, we proposed Larger Results via Sidecar Logs. This feature was added in release v0.43 as an alpha feature that's guarded behind the results-from feature flag. For further details, see the documentation.

This is an issue to gather feedback from users who have tried out the the feature, so that we can figure out a way forward.

jerop avatar Feb 08 '23 19:02 jerop

The larger results via sidecar logs is a huge improvement to address 4K termination message size limitation. I am evaluating using this feature in our service. This feature does not help accomplish artifacts use case but it is a step forward while working with a reasonable size of task results.

This is a live list of to-dos for making sure this feature can be promoted to beta:

  • [x] Fix formatting issues in docs and add a complete set of instructions on how to enable larger results using sidecar logs. The additional-configs has the set of instructions, either we move them under docs/tasks.md or provide a reference to additional-configs from docs/tasks.md.
  • [x] Add multiple tasks producing multiple task results in an example pipeline.
  • [x] Add an example pipeline which has a task producing large results + onError is set to continue. This test is necessary to check the sidecar sidecar-tekton-log-results supports non-zero exit code of any container.
  • [x] Add e2e test to validate the task results are produced with a failed task.
  • [x] Add an example pipeline to produce task results of all supported types including array and object.

pritidesai avatar Aug 01 '23 21:08 pritidesai

@pritidesai thank you for the feedback, will prioritize making the improvements that you've suggested

jerop avatar Aug 07 '23 17:08 jerop

@JeromeJu @pritidesai mentioned that larger results tests are gated by both the alpha flag as well as a dedicated feature flag. Can we use just one of them or is this intentional?

dibyom avatar Oct 03 '23 16:10 dibyom

@JeromeJu @pritidesai mentioned that larger results tests are gated by both the alpha flag as well as a dedicated feature flag. Can we use just one of them or is this intentional?

It is no longer gated behind the alpha feature flag - https://github.com/tektoncd/pipeline/pull/6939

jerop avatar Oct 03 '23 19:10 jerop

https://github.com/tektoncd/pipeline/pull/8041 adds the tests

chitrangpatel avatar Jun 10 '24 18:06 chitrangpatel