tektoncd
[TEP074] Remove Image pipelineResources
Changes
This commit removes the Image Resources support.
This PR removes github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/image
the imagedigestexporter and the docs for image resources.It also removes the
integration tests helm_task_test andhermetic_taskrun_test as these tests
are testing building against image resources.
Removal of pipelineResources, as in https://github.com/tektoncd/pipeline/issues/5967 has been broken up into removal of each resources according to small PRs.
Part of #5967 /kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [x] Has Docs included if any changes are user facing
- [x] Has Tests included if any functionality added or changed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
action required: please migrate off of `image` `pipelineresources` as it is removed, please refer to the doc at https://github.com/tektoncd/pipeline/blob/main/docs/pipelineresources.md#replacing-an-image-resource
`imagedigestexporter` image will not be built nor maintained from now on
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 83.6% | 83.9% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
TestHelmDeployPipelineRun and TestKanikoTaskRun are highly dependent on imagedigestexporter, I am trying to figure out in which way shall we refactor these tests?
TestHelmDeployPipelineRun and TestKanikoTaskRun are highly dependent on
imagedigestexporter, I am trying to figure out in which way shall we refactor these tests?
Can you replace the PipelineResources in these test cases with Tasks, following the migration guide?
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 84.5% | 84.8% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 84.5% | 84.8% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
TestHelmDeployPipelineRun and TestKanikoTaskRun are highly dependent on
imagedigestexporter, I am trying to figure out in which way shall we refactor these tests?Can you replace the PipelineResources in these test cases with Tasks, following the migration guide?
I want to change my feedback here-- I don't think these tests actually have value without the image pipelineresource, so you can go ahead and remove them.
In this PR, one question regarding removing the image resource at https://github.com/tektoncd/pipeline/pull/6002 is that dependencies is within the apis at https://github.com/tektoncd/pipeline/pull/6002. But the image resources api itself is being removed in this PR. Then in this case, there are 2 options to move forward:
- etracting the image resources logics to /pkg/image to keep the imagedigestexporter image without image resources apis
- remove the imageDigestExporter with this removal of image resources
Isn't imagedigestexporter part of the image resource?
I think so, so according to the dependencies we shall remove it along with the removal of the image pipelineResources apis?
But when digging around I found it used at https://github.com/tektoncd/catalog/blob/v1beta1/kaniko/kaniko.yaml#L49 🤔
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 84.5% | 84.8% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 84.5% | 84.8% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 84.5% | 84.8% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.6% | 97.9% | -1.7 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 94.9% | 94.7% | -0.3 |
| pkg/reconciler/taskrun/resources/output_resource.go | 89.1% | 87.0% | -2.2 |
| pkg/reconciler/taskrun/taskrun.go | 84.5% | 84.8% | 0.3 |
| pkg/reconciler/taskrun/validate_resources.go | 98.5% | 98.1% | -0.4 |