pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

Published 20 hours ago • verified publisher icon tektoncd

TEP-0097 breakpoints for taskrun

Open chengjoey opened this issue 3 years ago • 41 comments

Changes

breakpoints for taskrun, breakpoint beforesteps and aftersteps

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [x] Has Docs included if any changes are user facing
  • [x] Has Tests included if any functionality added or changed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

1. breakpoint on failure of a step was moved to `breakpoints.onFailure` spec
2. breakpoint before a step
3. breakpoint after a step

chengjoey avatar Oct 27 '22 08:10 chengjoey

Hi @chengjoey. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Oct 27 '22 08:10 tekton-robot

/kind feature

chengjoey avatar Oct 27 '22 08:10 chengjoey

/assign @waveywaves

chengjoey avatar Oct 27 '22 08:10 chengjoey

/ok-to-test /assign

vdemeester avatar Oct 27 '22 13:10 vdemeester

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 13.6% 15.7% 2.1
pkg/apis/pipeline/v1/taskrun_types.go 76.9% 82.1% 5.2
pkg/apis/pipeline/v1/taskrun_validation.go 98.4% 95.4% -3.0
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.9% 86.2% -7.7
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.2% 82.9% 4.7
pkg/apis/pipeline/v1beta1/taskrun_validation.go 98.4% 95.4% -3.0
pkg/entrypoint/entrypointer.go 84.8% 72.2% -12.7
pkg/pod/entrypoint.go 89.5% 90.4% 0.9
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Oct 27 '22 13:10 tekton-robot

https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/5691/pull-tekton-pipeline-build-tests/1585627748104146944 lists the code need to be fixed. Most of them are missing comments of exported functions

Yongxuanzhang avatar Oct 27 '22 14:10 Yongxuanzhang

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 13.6% 15.7% 2.1
pkg/apis/pipeline/v1/taskrun_types.go 76.9% 82.1% 5.2
pkg/apis/pipeline/v1/taskrun_validation.go 98.4% 95.4% -3.0
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.9% 86.2% -7.7
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.2% 82.9% 4.7
pkg/apis/pipeline/v1beta1/taskrun_validation.go 98.4% 95.4% -3.0
pkg/entrypoint/entrypointer.go 84.8% 72.2% -12.7
pkg/pod/entrypoint.go 89.5% 90.4% 0.9
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Oct 27 '22 15:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 13.6% 15.7% 2.1
pkg/apis/pipeline/v1/taskrun_types.go 76.9% 82.1% 5.2
pkg/apis/pipeline/v1/taskrun_validation.go 98.4% 95.4% -3.0
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.9% 86.2% -7.7
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.2% 82.9% 4.7
pkg/apis/pipeline/v1beta1/taskrun_validation.go 98.4% 95.4% -3.0
pkg/entrypoint/entrypointer.go 84.8% 72.2% -12.7
pkg/pod/entrypoint.go 89.5% 90.4% 0.9
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Oct 28 '22 02:10 tekton-robot

/retest

chengjoey avatar Oct 28 '22 02:10 chengjoey

/retest

chengjoey avatar Oct 28 '22 02:10 chengjoey

/retest

chengjoey avatar Oct 28 '22 05:10 chengjoey

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 13.6% 15.7% 2.1
pkg/apis/pipeline/v1/taskrun_types.go 76.9% 82.1% 5.2
pkg/apis/pipeline/v1/taskrun_validation.go 98.4% 95.4% -3.0
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.9% 86.2% -7.7
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.2% 82.9% 4.7
pkg/apis/pipeline/v1beta1/taskrun_validation.go 98.4% 95.4% -3.0
pkg/entrypoint/entrypointer.go 84.8% 72.2% -12.7
pkg/pod/entrypoint.go 89.5% 90.4% 0.9
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Oct 28 '22 06:10 tekton-robot

/retest

chengjoey avatar Oct 29 '22 08:10 chengjoey

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 14.5% 1.8
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 88.5% -3.8
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 75.9% -12.0
pkg/pod/entrypoint.go 89.8% 88.4% -1.4
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Dec 30 '22 06:12 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-using-tekton to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 14.5% 1.8
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 88.5% -3.8
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 75.9% -12.0
pkg/pod/entrypoint.go 89.8% 88.4% -1.4
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Dec 30 '22 06:12 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 14.5% 1.8
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 88.5% -3.8
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 75.9% -12.0
pkg/pod/entrypoint.go 89.8% 90.5% 0.8
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Dec 30 '22 08:12 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-using-tekton to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 14.5% 1.8
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 88.5% -3.8
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 75.9% -12.0
pkg/pod/entrypoint.go 89.8% 90.5% 0.8
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Dec 30 '22 09:12 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 14.5% 1.8
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 89.8% -2.5
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 75.9% -12.0
pkg/pod/entrypoint.go 89.8% 90.5% 0.8
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Jan 03 '23 07:01 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-using-tekton to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 14.5% 1.8
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 89.8% -2.5
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 75.9% -12.0
pkg/pod/entrypoint.go 89.8% 90.5% 0.8
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Jan 03 '23 07:01 tekton-robot

@waveywaves please take a look 🙏🏾

jerop avatar Feb 02 '23 14:02 jerop

Thank you @chengjoey for the PR 🙏

I am starting to review this PR but didn't find much documentation. Please add necessary documentation since this is a feature enhancement and revisit the submitters checklist in the PR description.

pritidesai avatar Feb 03 '23 18:02 pritidesai

Thank you @chengjoey for the PR 🙏

I am starting to review this PR but didn't find much documentation. Please add necessary documentation since this is a feature enhancement and revisit the submitters checklist in the PR description.

ok, i will add soon. since this pr has been submitted for a long time, I need to recheck it

chengjoey avatar Feb 04 '23 10:02 chengjoey

hi @pritidesai @waveywaves , I added some docs about this feature, thanks for reviewing my pr

chengjoey avatar Feb 06 '23 13:02 chengjoey

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 13.6% 0.9
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 89.8% -2.5
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 69.1% -18.8
pkg/pod/entrypoint.go 89.8% 89.9% 0.1
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Feb 06 '23 13:02 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 13.6% 0.9
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 89.8% -2.5
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 69.1% -18.8
pkg/pod/entrypoint.go 89.8% 89.9% 0.1
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Feb 06 '23 13:02 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 13.6% 0.9
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 89.8% -2.5
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 69.1% -18.8
pkg/pod/entrypoint.go 89.8% 89.9% 0.1
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Feb 06 '23 13:02 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 13.6% 0.9
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 89.8% -2.5
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 69.1% -18.8
pkg/pod/entrypoint.go 89.8% 89.9% 0.1
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Feb 06 '23 13:02 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 13.6% 0.9
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 89.8% -2.5
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 69.1% -18.8
pkg/pod/entrypoint.go 89.8% 89.9% 0.1
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Feb 06 '23 13:02 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 13.6% 0.9
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 89.8% -2.5
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 69.1% -18.8
pkg/pod/entrypoint.go 89.8% 89.9% 0.1
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Feb 06 '23 13:02 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.7% 13.6% 0.9
pkg/apis/pipeline/v1/taskrun_types.go 77.4% 82.4% 5.0
pkg/apis/pipeline/v1/taskrun_validation.go 97.7% 95.0% -2.8
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.3% 89.8% -2.5
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.6% 83.1% 4.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.8% 95.0% -2.8
pkg/entrypoint/entrypointer.go 87.8% 69.1% -18.8
pkg/pod/entrypoint.go 89.8% 89.9% 0.1
pkg/pod/script.go 100.0% 96.0% -4.0

tekton-robot avatar Feb 06 '23 14:02 tekton-robot