pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard
verified publisher icon tektoncd

Add the ability to mock more SCM data for git resolver tests

Open abayer opened this issue 3 years ago • 4 comments

Changes

Specifically, it adds the ability to cheat a "fake" list of repositories into the SCM client for use in adding the clone URL to the resolved resource annotations, as needed in #5397.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [ ] Has Docs included if any changes are user facing
  • [x] Has Tests included if any functionality added or changed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

abayer avatar Sep 21 '22 16:09 abayer

/assign @chuangw6 @lbernick @vdemeester

abayer avatar Sep 21 '22 16:09 abayer

@abayer: GitHub didn't allow me to assign the following users: chuangw6.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @chuangw6 @lbernick @vdemeester

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Sep 21 '22 16:09 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/git/resolver.go 84.6% 84.8% 0.1

tekton-robot avatar Sep 21 '22 17:09 tekton-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuangw6, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Sep 22 '22 10:09 tekton-robot

/hold

@lbernick How's https://github.com/tektoncd/pipeline/pull/5531/commits/69171b7362b96d25786172fe01b5c0b4981fe3d0?

abayer avatar Sep 22 '22 13:09 abayer

I like that approach!

lbernick avatar Sep 22 '22 14:09 lbernick

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/git/resolver.go 84.6% 83.9% -0.8

tekton-robot avatar Sep 22 '22 14:09 tekton-robot

woo! Squashing it down now.

abayer avatar Sep 22 '22 14:09 abayer

/hold cancel

abayer avatar Sep 22 '22 14:09 abayer

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/git/resolver.go 84.6% 83.9% -0.8

tekton-robot avatar Sep 22 '22 14:09 tekton-robot

/lgtm

lbernick avatar Sep 22 '22 15:09 lbernick