pipeline
pipeline copied to clipboard
tektoncd
Make pipeline cancel robust to missing resources
Changes
When a pipelinerun is cancelled, it may be that some of the resources managed by the pipelinerun are missing (NotFound). In this case we should not fail, and let the pipelinerun be cancelled.
Discussion about this was initially triggered by https://github.com/tektoncd/pipeline/issues/5282, but this feature makes sense regardless of the bug that exposed its need.
Signed-off-by: Andrea Frittoli [email protected]
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [ ] Has Docs included if any changes are user facing
- [x] Has Tests included if any functionality added or changed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
A PipelineRun can be cancelled even if some of its owned resources have been deleted.
/kind feature
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/cancel.go | 93.0% | 93.7% | 0.7 |
@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
-
/test pull-tekton-pipeline-alpha-integration-tests -
/test pull-tekton-pipeline-build-tests -
/test pull-tekton-pipeline-integration-tests -
/test tekton-pipeline-unit-tests
The following commands are available to trigger optional jobs:
-
/test pull-tekton-pipeline-go-coverage
Use /test all to run all jobs.
In response to this:
/test pull-tekton-pipeline-unit-tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
-
/test pull-tekton-pipeline-alpha-integration-tests -
/test pull-tekton-pipeline-build-tests -
/test pull-tekton-pipeline-integration-tests -
/test tekton-pipeline-unit-tests
The following commands are available to trigger optional jobs:
-
/test pull-tekton-pipeline-go-coverage
Use /test all to run all jobs.
In response to this:
/test pull-tekton-pipeline-unit-tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@abayer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
-
/test pull-tekton-pipeline-alpha-integration-tests -
/test pull-tekton-pipeline-build-tests -
/test pull-tekton-pipeline-integration-tests -
/test tekton-pipeline-unit-tests
The following commands are available to trigger optional jobs:
-
/test pull-tekton-pipeline-go-coverage
Use /test all to run all jobs.
In response to this:
/test check-pr-has-kind-label
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abayer, vdemeester
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [abayer,vdemeester]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment