pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

Add conversion for v1 TaskRun

Open JeromeJu opened this issue 3 years ago • 3 comments

Changes

This commit adds conversion functions between v1beta1 and v1 TaskRun. It does not handle fields deprecated in v1beta1 that will not be present in v1. It implements ConvertTo and ConvertFrom for v1beta1 TaskRun, and leaves these functions unimplemented for v1 TaskRun, since it is the highest known version.

needs #5272

Part of #4985 /kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs included if any changes are user facing
  • [x] Has Tests included if any functionality added or changed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

JeromeJu avatar Aug 04 '22 20:08 JeromeJu

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

tekton-robot avatar Aug 04 '22 20:08 tekton-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Aug 23 '22 19:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_conversion.go Do not exist 66.7%

tekton-robot avatar Aug 25 '22 12:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 66.7% 96.0% 29.4

tekton-robot avatar Aug 25 '22 13:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 66.7% 96.0% 29.4

tekton-robot avatar Aug 25 '22 14:08 tekton-robot

/lgtm

dibyom avatar Aug 25 '22 16:08 dibyom