tektoncd
Fix Existing Requests and Limits with LimitRange
Changes
This PR is to update limitrange logic to ensure container's requests and limits under the min and max range which is configured by limitrange.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [x] Has Docs included if any changes are user facing
- [x] Has Tests included if any functionality added or changed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
Fixed Existing Requests and Limits with LimitRange
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/internal/computeresources/tasklevel/tasklevel.go | Do not exist | 100.0% | |
| pkg/internal/computeresources/transformer.go | 91.9% | 92.5% | 0.6 |
| pkg/pod/pod.go | 88.8% | 88.2% | -0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/internal/computeresources/tasklevel/tasklevel.go | Do not exist | 100.0% | |
| pkg/internal/computeresources/transformer.go | 91.9% | 92.3% | 0.4 |
| pkg/pod/pod.go | 88.8% | 88.2% | -0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/internal/computeresources/tasklevel/tasklevel.go | Do not exist | 100.0% | |
| pkg/internal/computeresources/transformer.go | 91.9% | 92.3% | 0.4 |
| pkg/pod/pod.go | 88.8% | 88.2% | -0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/internal/computeresources/transformer.go | 91.9% | 92.3% | 0.4 |
Could you please remove the TEP title from the commit message + PR description? since this is an unrelated bug fix.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/internal/computeresources/transformer.go | 91.9% | 92.3% | 0.4 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/internal/computeresources/transformer.go | 91.9% | 93.0% | 1.1 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abayer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [abayer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
thanks @abayer for the review!
pushed an update to ensure requests got "capped" by limits finally
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/internal/computeresources/transformer.go | 91.9% | 93.5% | 1.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/internal/computeresources/transformer.go | 91.9% | 94.1% | 2.2 |
@austinzhao-go: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-tekton-pipeline-integration-tests | 580012bef9150fa8816e4edb1c98cc2ce1c57be5 | link | true | /test pull-tekton-pipeline-integration-tests |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
closed the PR for this moment after a check with @lbernick
the expected fix will be updated in another PR.