pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard
verified publisher icon tektoncd

Add V1 TaskRun Golang structs

Open JeromeJu opened this issue 3 years ago • 6 comments

Changes

This commit adds structs and validation for v1 TaskRun, including pod, resultRef. This is copied from v1beta1 with the following exceptions:

  • omitted TaskRunResources
    • This includes the TaskRunInputs and TaskRunOutputs and respective test

TODO:

  • [ ] Sync with #5143

Part of #4985 /kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs included if any changes are user facing
  • [x] Has Tests included if any functionality added or changed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

JeromeJu avatar Aug 03 '22 15:08 JeromeJu

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

tekton-robot avatar Aug 03 '22 15:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pod.go Do not exist 0.0%
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 0.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 0.0%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 10 '22 15:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pod.go Do not exist 0.0%
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 0.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 0.0%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 10 '22 18:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pod.go Do not exist 0.0%
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 0.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 0.0%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 11 '22 21:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pod.go Do not exist 75.0%
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 100.0%

tekton-robot avatar Aug 12 '22 15:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pod.go Do not exist 75.0%
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 100.0%

tekton-robot avatar Aug 15 '22 20:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pod.go Do not exist 75.0%
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 16 '22 20:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 16 '22 20:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 16 '22 20:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 18 '22 16:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 19 '22 16:08 tekton-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Aug 19 '22 17:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 19 '22 17:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 23 '22 18:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 24 '22 13:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 24 '22 13:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 24 '22 13:08 tekton-robot

As this is a large PR and the changes are copied from v1beta1, put this PR for visualization for easier comparison.

JeromeJu avatar Aug 24 '22 14:08 JeromeJu

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 24 '22 14:08 tekton-robot

This LGTM. Can you squash up the commits?

dibyom avatar Aug 24 '22 15:08 dibyom

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 24 '22 17:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/taskrun_types.go Do not exist 77.2%
pkg/apis/pipeline/v1/taskrun_validation.go Do not exist 0.0%

tekton-robot avatar Aug 24 '22 18:08 tekton-robot

Thanks @dibyom, squashed and retested.

JeromeJu avatar Aug 24 '22 18:08 JeromeJu

/lgtm

abayer avatar Aug 24 '22 20:08 abayer