pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

Add conversion for v1 Pipeline

Open JeromeJu opened this issue 3 years ago • 16 comments

Changes

This commit adds conversion functions between v1beta1 and v1 Pipeline. It does not handle fields deprecated in v1beta1 that will not be present in v1. It implements ConvertTo and ConvertFrom for v1beta1 Pipeline, and leaves these functions unimplemented for v1 Pipeline, since it is the highest known version.

Conversions for all types are basically deep copies, rather than using the same struct definition for both API versions. This will allow us to iterate on v1 without making additional changes to v1beta1, after v1 is the stored version.

Handle resources regarding #5253

Part of #4986 /kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs included if any changes are user facing
  • [x] Has Tests included if any functionality added or changed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

JeromeJu avatar Aug 02 '22 18:08 JeromeJu

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

tekton-robot avatar Aug 02 '22 18:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 66.7% 99.4% 32.7
pkg/apis/pipeline/v1beta1/resolver_conversion.go Do not exist 37.5%
pkg/apis/pipeline/v1beta1/taskref_conversion.go Do not exist 100.0%

tekton-robot avatar Aug 09 '22 18:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 66.7% 99.4% 32.7
pkg/apis/pipeline/v1beta1/resolver_conversion.go Do not exist 37.5%
pkg/apis/pipeline/v1beta1/taskref_conversion.go Do not exist 100.0%

tekton-robot avatar Aug 09 '22 18:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 66.7% 99.4% 32.7
pkg/apis/pipeline/v1beta1/resolver_conversion.go Do not exist 37.5%
pkg/apis/pipeline/v1beta1/taskref_conversion.go Do not exist 100.0%

tekton-robot avatar Aug 09 '22 18:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 66.7% 98.2% 31.5
pkg/apis/pipeline/v1beta1/resolver_conversion.go Do not exist 37.5%
pkg/apis/pipeline/v1beta1/taskref_conversion.go Do not exist 100.0%

tekton-robot avatar Aug 09 '22 18:08 tekton-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Aug 09 '22 19:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 66.7% 99.4% 32.7
pkg/apis/pipeline/v1beta1/resolver_conversion.go Do not exist 37.5%
pkg/apis/pipeline/v1beta1/taskref_conversion.go Do not exist 100.0%

tekton-robot avatar Aug 10 '22 14:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 66.7% 98.1% 31.5
pkg/apis/pipeline/v1beta1/resolver_conversion.go Do not exist 37.5%
pkg/apis/pipeline/v1beta1/taskref_conversion.go Do not exist 100.0%

tekton-robot avatar Aug 10 '22 16:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 66.7% 95.8% 29.2
pkg/apis/pipeline/v1beta1/resolver_conversion.go Do not exist 37.5%
pkg/apis/pipeline/v1beta1/taskref_conversion.go Do not exist 100.0%

tekton-robot avatar Aug 10 '22 18:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 66.7% 95.8% 29.2
pkg/apis/pipeline/v1beta1/resolver_conversion.go Do not exist 37.5%
pkg/apis/pipeline/v1beta1/taskref_conversion.go Do not exist 100.0%

tekton-robot avatar Aug 10 '22 20:08 tekton-robot

/test pull-tekton-pipeline-build-tests

dibyom avatar Aug 10 '22 21:08 dibyom

/lgtm

dibyom avatar Aug 11 '22 18:08 dibyom