pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

Clarify error message for verify-codegen.sh

Open abayer opened this issue 3 years ago • 4 comments

Changes

It currently says to run both hack/update-codegen.sh and hack/update-openapigen.sh, but hack/update-codegen.sh actually calls hack/update-openapigen.sh. So let's make the message actually match all that you need to do.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [ ] Has Docs included if any changes are user facing
  • [ ] Has Tests included if any functionality added or changed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

abayer avatar Aug 02 '22 15:08 abayer

/assign @jerop @afrittoli @lbernick

abayer avatar Aug 02 '22 15:08 abayer

/retest

abayer avatar Aug 02 '22 16:08 abayer

@JeromeJu it seems like you had some issues here with update-codegen not actually running update-openapigen when you expected it to?

lbernick avatar Aug 02 '22 16:08 lbernick

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Aug 18 '22 14:08 tekton-robot

/lgtm

vdemeester avatar Aug 23 '22 14:08 vdemeester

/test check-pr-has-kind-label

abayer avatar Aug 23 '22 16:08 abayer

@abayer: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 23 '22 16:08 tekton-robot