Bump HorizontalPodAutoscaler apiVersion to v2

[vdemeester]

Changes

Before this, we get a warning when applying the HPA:

Warning: autoscaling/v2beta1 HorizontalPodAutoscaler is deprecated in v1.22+, unavailable in v1.25+; use autoscaling/v2 HorizontalPodAutoscaler

Signed-off-by: Vincent Demeester [email protected]

Closes #5128 Takes over #4896

/cc @afrittoli @abayer @imjasonh @lbernick @jerop @pritidesai

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [x] Has Docs included if any changes are user facing
• [ ] Has Tests included if any functionality added or changed
• [x] Follows the commit message standard
• [x] Meets the Tekton contributor standards (including functionality, content, code)
• [ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Webhook HPA uses autoscaling/v2 instead of the deprecated autoscaling/v2beta1

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [afrittoli]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/kind misc

[vdemeester]

Alright, this fails because apiVersion: autoscaling/v2, kind: HorizontalPodAutoscaler is available starting with 1.23. So v2beta1 is, weirdly enough, deprecated in 1.22+ but the v2 is only available in 1.23.

Bumping to autoscaling/v2 would effectively mean we require a minimum version of kubernetes to be 1.23. We, most likely, will have to do this before or at the same time as kubernetes 1.25 goes out or is "widely" available.

/cc @imjasonh @afrittoli @abayer @tektoncd/core-maintainers

See https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/ and https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/

[vdemeester]

/hold

[vdemeester]

/retest

[abayer]

/retest

[dibyom]

/retest

[vdemeester]

Alright, so I was wrong, it's not 1.22 that is required, but 1.23... 😅

[vdemeester]

In a gist, we need to bump our minimal k8s version to 1.23 to be able to support 1.25 🙃

[vdemeester]

It does require https://github.com/tektoncd/plumbing/pull/1238 🙃

[dibyom]

In a gist, we need to bump our minimal k8s version to 1.23 to be able to support 1.25 🙃

1.22 EOL is coming up on 2022-10-28 so bumping min to 1.23 makes sense 👍

https://kubernetes.io/releases/#release-v1-22

[vdemeester]

/retest I think kind should use 1.23 now 🙃

[abayer]

/lgtm

[vdemeester]

/hold cancel