pipeline
pipeline copied to clipboard
tektoncd
TEP-0111 - Propagating workspaces
The verbosity of writing specifications in Tekton Pipelines is a common pain point that creates difficulties in getting-started scenarios. In addition, the verbosity leads to long specifications that are error-prone, harder to maintain, and reach the etcd size limits for CRDs. Automatically propagating Workspaces will lead to better user experience. This addresses features proposed in TEP-0111.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [x] Docs included if any changes are user facing
- [x] Tests included if any functionality added or changed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")
Release Notes
Workspaces are propagated in embedded specifications without mutations.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 86.2% | 84.7% | -1.5 |
| pkg/reconciler/taskrun/taskrun.go | 80.9% | 80.9% | -0.0 |
| pkg/workspace/apply.go | 100.0% | 98.8% | -1.2 |
| pkg/workspace/validate.go | 100.0% | 96.3% | -3.7 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 86.2% | 84.7% | -1.5 |
| pkg/reconciler/taskrun/taskrun.go | 80.9% | 80.9% | -0.0 |
| pkg/workspace/apply.go | 100.0% | 98.8% | -1.2 |
| pkg/workspace/validate.go | 100.0% | 96.3% | -3.7 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 86.2% | 84.7% | -1.5 |
| pkg/reconciler/taskrun/taskrun.go | 80.9% | 80.9% | -0.0 |
| pkg/workspace/apply.go | 100.0% | 98.8% | -1.2 |
| pkg/workspace/validate.go | 100.0% | 96.3% | -3.7 |
@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test pull-tekton-pipeline-alpha-integration-tests/test pull-tekton-pipeline-build-tests/test pull-tekton-pipeline-integration-tests/test tekton-pipeline-unit-tests
The following commands are available to trigger optional jobs:
/test pull-tekton-pipeline-go-coverage/test pull-tekton-pipeline-kind-alpha-integration-tests/test pull-tekton-pipeline-kind-alpha-yaml-tests/test pull-tekton-pipeline-kind-integration-tests/test pull-tekton-pipeline-kind-yaml-tests
Use /test all to run the following jobs that were automatically triggered:
pull-tekton-pipeline-alpha-integration-testspull-tekton-pipeline-build-testspull-tekton-pipeline-go-coveragepull-tekton-pipeline-integration-testspull-tekton-pipeline-unit-tests
In response to this:
/test check-pr-has-kind-label
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 86.2% | 84.7% | -1.5 |
| pkg/reconciler/taskrun/taskrun.go | 80.9% | 80.9% | -0.0 |
| pkg/workspace/apply.go | 100.0% | 98.8% | -1.2 |
| pkg/workspace/validate.go | 100.0% | 96.3% | -3.7 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 86.3% | 84.8% | -1.5 |
| pkg/reconciler/taskrun/taskrun.go | 80.9% | 80.9% | -0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 86.3% | 84.8% | -1.5 |
| pkg/reconciler/taskrun/taskrun.go | 80.9% | 80.9% | -0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 86.3% | 85.4% | -0.9 |
| pkg/reconciler/taskrun/taskrun.go | 80.9% | 80.9% | -0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 86.3% | 86.2% | -0.1 |
| pkg/reconciler/taskrun/taskrun.go | 80.9% | 80.9% | -0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 86.3% | 86.6% | 0.2 |
| pkg/reconciler/taskrun/taskrun.go | 80.9% | 80.9% | -0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 85.8% | 86.1% | 0.2 |
| pkg/reconciler/taskrun/taskrun.go | 80.3% | 80.3% | -0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 85.8% | 86.1% | 0.2 |
| pkg/reconciler/taskrun/taskrun.go | 80.3% | 80.3% | -0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 85.8% | 86.1% | 0.2 |
| pkg/reconciler/taskrun/taskrun.go | 80.3% | 80.3% | -0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/reconciler/pipelinerun/pipelinerun.go | 85.8% | 86.1% | 0.2 |
| pkg/reconciler/taskrun/taskrun.go | 80.3% | 80.3% | -0.0 |
@jerop This is ready for review again. @dibyom please take a look again as there were a few changes (I incorporated your suggestions as best as I could) after bug fixes related to propagating parameters.