pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

add functionality that cancels the TaskRun when the pod encounters an error such as InvalidImageName

Open yuzp1996 opened this issue 2 years ago • 4 comments

Feature request

Add functionality to cancel the taskrun when the pod encounters an error that maybe can not be fixed like InvalidImageName

Use case

When the taskrun related pod is pending for some image error, we should let users choose if they want to cancel the taskrun or not. For example, when the pod is pending for InvalidImageName the user may want to cancel the taskrun.

related discussion: https://github.com/tektoncd/pipeline/pull/4846#discussion_r877065970

yuzp1996 avatar May 19 '22 14:05 yuzp1996

related PR: https://github.com/tektoncd/pipeline/pull/4618

yuzp1996 avatar May 19 '22 14:05 yuzp1996

I don't think it should be possible to create a TaskRun with an invalid image name, since we parse and lookup the requested image in order to resolve the entrypoint.

I suppose it's possible that if the image is specified by digest and the command is set, we might not do the lookup (I'm not sure, I'd have to check), and that in that case if the specified image name is invalid, we'd let it proceed and create the Pod, but in general I think the answer is to validate and fail early in that case instead of letting the Pod run until the image name can be corrected.

imjasonh avatar May 19 '22 14:05 imjasonh

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 17 '22 15:08 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Sep 16 '22 15:09 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Oct 16 '22 15:10 tekton-robot

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Oct 16 '22 15:10 tekton-robot