operator
operator copied to clipboard
docs: add keep-since to TektonConfig docs
Changes
- Adds keep-since to TektonConfig docs
- Type Declaration: https://github.com/tektoncd/operator/blob/main/pkg/apis/operator/v1alpha1/tektonconfig_types.go#L58-L61
- Mutually exclusive keep and keep-since: https://github.com/tektoncd/operator/blob/main/pkg/apis/operator/v1alpha1/tektonconfig_validation.go#L77-L81
- Fixes tektoncd/website#419, RHDEVDOCS-4312
- Blocked by #1025
Signed-off-by: Avinal Kumar [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
- [ ] Run
make test lint
before submitting a PR - [ ] Includes tests (if functionality changed/added)
- [x] Includes docs (if user facing)
- [x] Commit messages follow commit message best practices
Release Notes
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign vincent-pli after the PR has been reviewed.
You can assign the PR to them by writing /assign @vincent-pli
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: avinal / name: Avinal Kumar (c5fef2adf72e361a00bdff82d7d9ef3ee5cd2c2e)
Hi @avinal. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@avinal: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen
with a justification.
/lifecycle stale
Send feedback to tektoncd/plumbing.
Closing in favor of #1025