operator
operator copied to clipboard
tektoncd
Generate standalone CRDs manifests and update Helm chart in release pipeline
As discussed in https://github.com/tektoncd/operator/issues/793 it would be useful to have separate CRD.yaml manifests attached to the Github releases. While I'm working on modifying the pipeline, I also added a small change that will automatically set the correct version on the Helm chart when a new release is created.
Changes
- Generate standalone CRDs manifests attached to the Github releases - fixes https://github.com/tektoncd/operator/issues/793
- Update image versions used in Helm chart when creating a new release - fixes https://github.com/tektoncd/operator/issues/792
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
- [ ] ~~Includes tests (if functionality changed/added)~~
- [ ] ~~Includes docs (if user facing)~~
- [x] Commit messages follow commit message best practices
See the contribution guide for more details.
@jacksgt: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign houshengbo
You can assign the PR to them by writing /assign @houshengbo in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @jacksgt. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The PR https://github.com/tektoncd/plumbing/pull/1086 got merged, so yq is now included in the ko-gcloud image.
I updated the commands accordingly for extracting the CRD manifests.
Any other comments? @nikhil-thomas
@jacksgt quick note, it might take a couple of ours before the new image is used/available on the CI 🙃
hi @jacksgt thanks for your works, can I expecting automatic release on operatorhub will make a progress after this merge?
related: https://github.com/tektoncd/operator/issues/733
hi @jacksgt thanks for your works, can I expecting automatic release on operatorhub will make a progress after this merge?
related: #733
Not yet I would say.
/ok-to-test
Could someone please test the release process? I don't really have the necessary environment available.
@jacksgt: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle stale
Send feedback to tektoncd/plumbing.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle rotten
Send feedback to tektoncd/plumbing.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/close
Send feedback to tektoncd/plumbing.
@tekton-robot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopenwith a justification. Mark the issue as fresh with/remove-lifecycle rottenwith a justification. If this issue should be exempted, mark the issue as frozen with/lifecycle frozenwith a justification./close
Send feedback to tektoncd/plumbing.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.