operator icon indicating copy to clipboard operation
operator copied to clipboard

Support "patch" operations which do not add an ownerReference with TektonInstallerSet

Open nikhil-thomas opened this issue 2 years ago • 1 comments

Feature request

At present, whenever we use an InstallerSet instance to create/edit a resource, the installer set instance adds itself as an ownerReference. This addition of ownerReference is useful while working with a full installation of a component. However, this restricts us from using TektonInstaller set as a tool to patch/edit existing resources without touching the ownerReference. For example, adding/removing a label.

Use case

Imagine we are installing components like Pipelines, Triggers using TektonPipelines CRD and TektonTriggers CRD without using TekonConfig CRD. We want to add some labels to targetNamespace from each of the component installation indicating that the namespace is being used by that component. During uninstallation if we want to remove only the labels from the namespace without deleting the namespace, at present we have to use namespace client and do some explicit (imperative) editing.

Instead of this if we can support patch operations (with no ownerReference coupling) through InstallerSets we can achieve the label manipulation more efficiently. As we will not have to deal with directly using namespace api.

nikhil-thomas avatar May 13 '22 00:05 nikhil-thomas

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 11 '22 01:08 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Sep 10 '22 01:09 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Oct 10 '22 01:10 tekton-robot

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Oct 10 '22 01:10 tekton-robot