Reconcilers should not create/recreate resources if "deletionTimestamp" is set on the primary resource

[nikhil-thomas]

Expected Behavior

Deleting TektonConfig Instance should delete instances of TektonPipelines, TektonTriggers etc and the reconciler should not respond to that by trying to create TektonPipelines instances again.

Actual Behavior

Deletion of TektonPipeline instances by TektonConfig reconciler triggers the recreation of TektonPipelines instances irrespective of whether a deletion timestamp is set on TektonConfig instances.

Steps to Reproduce the Problem

1. Install operator
2. watch TektonConfig, TektonPipeline, TektonTriggers instances
3. Delete TektonConfig instance. We can see TektonPipeline Instance getting deleted then getting created momentarily before being deleted again.

[tekton-robot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.