operator icon indicating copy to clipboard operation
operator copied to clipboard

Requeue and Retry Tektoncd Pipeline upgrade if there are active TaskRuns

Open nikhil-thomas opened this issue 3 years ago • 4 comments

Feature request

The operator should make sure that there are no active TaskRuns before carrying out a Tektoncd Pipeline upgrade.

Use case

Internal changes in Tektoncd Pipeline could break active TaskRuns after an upgrade. For example: If we add/filtering of Pods in Pipelines controller, Pods created by an older version of Pipelines controller will not be visible to a newer Pipelines controller.

To ensure, that there are not unpleasant surprises (eg: TaskRun failure during a Pipeline Upgrade), we need to make sure that the operator waits and retries an upgrade if there are active TaskRuns.

Ref:

  • https://github.com/tektoncd/pipeline/issues/4398

nikhil-thomas avatar Dec 13 '21 23:12 nikhil-thomas

we can think of a more generic check, something like is_upgrade_ready() for each component (Pipelines, Triggers, Hub...) to make sure that necessary housekeeping tasks are carried out before the operator rollsout a component upgrade.

nikhil-thomas avatar Dec 13 '21 23:12 nikhil-thomas

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Mar 14 '22 00:03 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Apr 13 '22 00:04 tekton-robot

/lifecycle frozen Most likely something we still want to explore (or explicitely say we don't want to do it after some exploration)

vdemeester avatar Apr 13 '22 05:04 vdemeester