Add ko version instead of using latest
Changes
Multi arch builds are failing with the below error. go: github.com/google/ko@latest: github.com/google/[email protected] requires go >= 1.25.0 (running go 1.24.1; GOTOOLCHAIN=local)
hence adding ko version explicitly
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
- [ ] Run
make test lintbefore submitting a PR - [ ] Includes tests (if functionality changed/added)
- [ ] Includes docs (if user facing)
- [ ] Commit messages follow commit message best practices
See the contribution guide for more details.
Release Notes
NONE
/retest
/approve
@mbpavan Instead of pinning the version of ko can we update the ci workflow to use the installed ko version - by replacing https://github.com/tektoncd/operator/blob/main/.github/workflows/ci.yaml#L144-L145 with
# Kubernetes
KO_DOCKER_REPO=example.com \
kustomize build --load-restrictor LoadRestrictionsNone config/kubernetes/overlays/default | \
ko resolve --push=false --platform=all \
--oci-layout-path=.bin/oci -f -
# OpenShift
KO_DOCKER_REPO=example.com \
kustomize build --load-restrictor LoadRestrictionsNone config/openshift/overlays/default | \
ko resolve --push=false --platform=all \
--oci-layout-path=.bin/oci -f -
This way we do not fix the ko version to an older version. The the ci workflow uses the version of ko installed in the previous step rather than building one more time?
/approve cancel
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from mbpavan after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mbpavan @jkhelil - Thanks for the discussion. I shall mark this PR on hold. In any case we need to fix the make file so that make apply for contributors works smooth while the CI will be fixed with a separate PR that decouples ci workflow from leveraging the make resolve
/hold