operator icon indicating copy to clipboard operation
operator copied to clipboard
verified publisher icon tektoncd

Remove default Artifacthub url override

Open pratap0007 opened this issue 1 month ago • 11 comments

This patch includes the following changes:

  • Remove the default Hub catalog configuration from the PAC settings before PAC SyncConfig function call as this is already handled by the PAC SyncConfig function
  • Remove the default ArtifactHub URL override, which is managed by PAC.
  • Update the transform test to align with PAC changes, hub_url should not be fetchable, and PAC will now set the catalog type to tektonhub.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Run make test lint before submitting a PR
  • [ ] Includes tests (if functionality changed/added)
  • [ ] Includes docs (if user facing)
  • [ ] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE

pratap0007 avatar Dec 12 '25 04:12 pratap0007

I have verified fresh installation and upgrade with PAC PR , and it's working as expected.

pratap0007 avatar Dec 12 '25 04:12 pratap0007

/approve

mbpavan avatar Dec 12 '25 07:12 mbpavan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbpavan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Dec 12 '25 07:12 tekton-robot

@zakisk and @jkhelil can you take a look please

mbpavan avatar Dec 12 '25 07:12 mbpavan

/kind bug

anithapriyanatarajan avatar Dec 12 '25 10:12 anithapriyanatarajan

@pratap0007 - Is there a need to revert the changes done for https://github.com/tektoncd/operator/pull/3068

anithapriyanatarajan avatar Dec 13 '25 07:12 anithapriyanatarajan

@pratap0007 - Is there a need to revert the changes done for #3068

@anithapriyanatarajan I have included those change in this PR so there is no need to revert it

pratap0007 avatar Dec 13 '25 08:12 pratap0007

/cherry-pick release-v0.78.x

mbpavan avatar Dec 15 '25 07:12 mbpavan

❌ Cherry-pick to release-v0.78.x failed!

The automatic cherry-pick to release-v0.78.x failed.

Output:

🤖 Starting cherry-pick process...
Fetching PR #3091 information...
❌ ERROR: PR #3091 is not merged yet (state: OPEN). Cherry-pick requires merged PRs.

Next steps:

  • Check the action logs for complete details
  • If the PR is not merged, merge it first and try again
  • If there are conflicts, you'll need to manually cherry-pick this PR

tekton-robot avatar Dec 15 '25 07:12 tekton-robot

/unhold

pratap0007 avatar Dec 16 '25 04:12 pratap0007

/retest

pratap0007 avatar Dec 16 '25 06:12 pratap0007

/retest

pratap0007 avatar Dec 16 '25 12:12 pratap0007

/retest

anithapriyanatarajan avatar Dec 16 '25 13:12 anithapriyanatarajan

@anithapriyanatarajan @pratap0007 was the multi arch fixed in another PR ?

vdemeester avatar Dec 16 '25 14:12 vdemeester

@anithapriyanatarajan @pratap0007 was the multi arch fixed in another PR ?

Multiarch fixed with - https://github.com/tektoncd/operator/pull/3106.

anithapriyanatarajan avatar Dec 16 '25 14:12 anithapriyanatarajan

Then, this needs a rebase @pratap0007

vdemeester avatar Dec 16 '25 14:12 vdemeester

/lgtm

anithapriyanatarajan avatar Dec 16 '25 18:12 anithapriyanatarajan

/cherry-pick release-v0.78.x

divyansh42 avatar Dec 18 '25 05:12 divyansh42

/cherry-pick release-v0.78.x

mbpavan avatar Dec 18 '25 06:12 mbpavan

✅ Cherry-pick to release-v0.78.x successful!

A new pull request has been created to cherry-pick this change to release-v0.78.x.

Please review and merge the cherry-pick PR.

tekton-robot avatar Dec 18 '25 06:12 tekton-robot

/cherry-pick release-v0.78.x

mbpavan avatar Dec 18 '25 11:12 mbpavan

/cherry-pick release-v0.78.x

mbpavan avatar Dec 18 '25 11:12 mbpavan

✅ Cherry-pick to release-v0.78.x successful!

A new pull request has been created to cherry-pick this change to release-v0.78.x.

Please review and merge the cherry-pick PR.

tekton-robot avatar Dec 18 '25 11:12 tekton-robot

ℹ️ Cherry-pick to release-v0.78.x already exists!

A pull request for this cherry-pick already exists: #3120

PR: https://github.com/tektoncd/operator/pull/3120

tekton-robot avatar Dec 18 '25 11:12 tekton-robot