operator icon indicating copy to clipboard operation
operator copied to clipboard
verified publisher icon tektoncd

Fix: Pruner Config resetting to default when set to null

Open pramodbindal opened this issue 1 month ago • 5 comments

When HistoryLimit is set to null in tektonconfig then it resets back to 100 After this fix, value will be retained

This also fixes the issues of pruner config resetting to default on upgrade. Now after upgrade pruner should retain the old config

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [x] Run make test lint before submitting a PR
  • [x] Includes tests (if functionality changed/added)
  • [ ] Includes docs (if user facing)
  • [x] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE

pramodbindal avatar Dec 09 '25 09:12 pramodbindal

/kind bug

anithapriyanatarajan avatar Dec 09 '25 12:12 anithapriyanatarajan

/retest

anithapriyanatarajan avatar Dec 09 '25 17:12 anithapriyanatarajan

/lgtm

pratap0007 avatar Dec 10 '25 08:12 pratap0007

@pramodbindal Attempt to upgrade from 0.77.x to the pr code base either results in pruner controller crashloop or configmap value not retained. Could you please assess the upgrade scenario once and confirm the outcome please. Thankyou

anithapriyanatarajan avatar Dec 11 '25 12:12 anithapriyanatarajan

/hold

anithapriyanatarajan avatar Dec 19 '25 12:12 anithapriyanatarajan

LGTM

infernus01 avatar Dec 23 '25 06:12 infernus01

/approve

anithapriyanatarajan avatar Dec 23 '25 07:12 anithapriyanatarajan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anithapriyanatarajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [anithapriyanatarajan]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Dec 23 '25 07:12 tekton-robot

/hold cancel

anithapriyanatarajan avatar Dec 23 '25 07:12 anithapriyanatarajan

/lgtm

anithapriyanatarajan avatar Dec 23 '25 07:12 anithapriyanatarajan

@dependabot rebase

anithapriyanatarajan avatar Dec 23 '25 08:12 anithapriyanatarajan

/retest

anithapriyanatarajan avatar Dec 23 '25 09:12 anithapriyanatarajan

//lgtm

anithapriyanatarajan avatar Dec 23 '25 10:12 anithapriyanatarajan

/lgtm

anithapriyanatarajan avatar Dec 23 '25 10:12 anithapriyanatarajan

/cherry-pick release-v0.78.x

infernus01 avatar Dec 23 '25 10:12 infernus01

/cherry-pick release-v0.78.x

pramodbindal avatar Dec 23 '25 11:12 pramodbindal

✅ Cherry-pick to release-v0.78.x successful!

A new pull request has been created to cherry-pick this change to release-v0.78.x.

Please review and merge the cherry-pick PR.

tekton-robot avatar Dec 23 '25 11:12 tekton-robot