operator icon indicating copy to clipboard operation
operator copied to clipboard

Published 20 hours ago • verified publisher icon tektoncd

Remove creation of cluster task installersets

Open pratap0007 opened this issue 1 year ago • 6 comments

Changes

This patch will remove the creation of cluster task installersets but keep the existing cluster task installersets

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Run make test lint before submitting a PR
  • [ ] Includes tests (if functionality changed/added)
  • [ ] Includes docs (if user facing)
  • [ ] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

pratap0007 avatar Oct 16 '24 05:10 pratap0007

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

tekton-robot avatar Oct 16 '24 05:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

tekton-robot avatar Oct 18 '24 13:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

tekton-robot avatar Oct 18 '24 14:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

tekton-robot avatar Oct 21 '24 03:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

tekton-robot avatar Oct 21 '24 04:10 tekton-robot

cc @jkandasa

vdemeester avatar Nov 05 '24 10:11 vdemeester

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

tekton-robot avatar Nov 07 '24 10:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

tekton-robot avatar Nov 07 '24 12:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

tekton-robot avatar Nov 07 '24 23:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 11 '24 13:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 12 '24 03:11 tekton-robot

/retest

pratap0007 avatar Nov 12 '24 05:11 pratap0007

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 13 '24 09:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 14 '24 05:11 tekton-robot

@pratap0007 You need to change these templates https://github.com/tektoncd/operator/blob/main/cmd/openshift/operator/kodata/tekton-addon/tekton-pipeline-template/pipeline_using_workspace.yaml#L25-L26 to use the resolverTasks now instead of ClusterTask

Use below sample format instead of clusterTask

    tasks:
    - name: kn-run
      taskRef:
        resolver: cluster
        params:
        - name: kind
          value: task
        - name: name
          value: kn
        - name: namespace
          value: openshift-pipelines

savitaashture avatar Nov 14 '24 12:11 savitaashture

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 18 '24 06:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 90.9% 3.4
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 18 '24 17:11 tekton-robot

Thanks @savitaashture @PuneetPunamiya @ppitonak @jkhelil for review and I have updated, please take a final review

pratap0007 avatar Nov 18 '24 17:11 pratap0007

/retest

pratap0007 avatar Nov 18 '24 18:11 pratap0007

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 90.9% 3.4
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 19 '24 04:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 90.9% 3.4
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 19 '24 04:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 90.9% 3.4
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 19 '24 06:11 tekton-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Nov 19 '24 06:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 90.9% 3.4
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 19 '24 07:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 90.9% 3.4
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

tekton-robot avatar Nov 19 '24 10:11 tekton-robot

lgtm

jkhelil avatar Nov 19 '24 14:11 jkhelil

/lgtm

jkhelil avatar Nov 19 '24 14:11 jkhelil

LGTM

tested manually

  • Fresh install
    • ClusterTasks and related InstallerSets removed
  • Upgraded
    • ClusterTasks and related InstallerSets removed

savitaashture avatar Nov 19 '24 14:11 savitaashture

Fresh install ClusterTasks and related InstallerSets removed

@savitaashture on a fresh install, the ClusterTasks and related installerSets should not be installed, so nothing to remove. Can you please confirm?

jkandasa avatar Nov 19 '24 14:11 jkandasa