operator
operator copied to clipboard
Fix bitbucket clustertriggerbinding when both SSH and HTTPS enabled
Changes
Fixes #1702
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
- [ ] Run
make test lintbefore submitting a PR - [ ] Includes tests (if functionality changed/added)
- [ ] Includes docs (if user facing)
- [ ] Commit messages follow commit message best practices
See the contribution guide for more details.
Release Notes
/hold
currently it is not clear about the clone URL. I put this PR on HOLD, until we get a proper fix.
@jkandasa Issue is that current variable behaves in undefined way. Index shouldn't be used. We should use name to assign value.
@khrm
Issue is that current variable behaves in undefined way. Index shouldn't be used. We should use name to assign value.
I agree. But we should confirm gitlab has always ssh.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jkandasa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jkandasa]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold cancel
cc @piyush-garg
/lgtm