operator icon indicating copy to clipboard operation
operator copied to clipboard

Fix bitbucket clustertriggerbinding when both SSH and HTTPS enabled

Open khrm opened this issue 2 years ago • 6 comments

Changes

Fixes #1702

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Run make test lint before submitting a PR
  • [ ] Includes tests (if functionality changed/added)
  • [ ] Includes docs (if user facing)
  • [ ] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

khrm avatar Sep 15 '23 12:09 khrm

/hold

currently it is not clear about the clone URL. I put this PR on HOLD, until we get a proper fix.

jkandasa avatar Sep 16 '23 10:09 jkandasa

@jkandasa Issue is that current variable behaves in undefined way. Index shouldn't be used. We should use name to assign value.

khrm avatar Sep 16 '23 18:09 khrm

@khrm

Issue is that current variable behaves in undefined way. Index shouldn't be used. We should use name to assign value.

I agree. But we should confirm gitlab has always ssh.

jkandasa avatar Sep 19 '23 02:09 jkandasa

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar May 15 '24 09:05 tekton-robot

/hold cancel

jkandasa avatar May 15 '24 09:05 jkandasa

cc @piyush-garg

jkandasa avatar May 15 '24 09:05 jkandasa

/lgtm

piyush-garg avatar Jun 07 '24 09:06 piyush-garg