operator
operator copied to clipboard
tektoncd
No need to update object in ReconcilerKind
Changes
knative/pkg will do the update itself. Removing those calls as they would just make duplicate calls (and possibly call the API too often).
Signed-off-by: Vincent Demeester [email protected]
/kind misc /cc @sm43 @savitaashture @concaf
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
- [x] Run
make test lintbefore submitting a PR - [x] Includes tests (if functionality changed/added)
- [ ] Includes docs (if user facing)
- [x] Commit messages follow commit message best practices
See the contribution guide for more details.
Release Notes
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@vdemeester: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-tekton-operator-integration-tests | 4992ec6954e1c707d4b86e030dd1f2f60e60cedf | link | true | /test pull-tekton-operator-integration-tests |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@vdemeester: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.