operator icon indicating copy to clipboard operation
operator copied to clipboard

Add documentation for the `keep-since` field

Open Aldiuser opened this issue 2 years ago • 4 comments

Changes

Add documentation for the keep-since field. There is currently a mismatch between the fieldname and its actual behavior. Fore more information see #1047.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [x] Run make test lint before submitting a PR
  • [x] Includes tests (if functionality changed/added)
  • [x] Includes docs (if user facing)
  • [x] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Add documentation for the keep-since field

Aldiuser avatar Sep 08 '22 12:09 Aldiuser

@Aldiuser: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Sep 08 '22 12:09 tekton-robot

CLA Missing ID CLA Not Signed

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign vincent-pli after the PR has been reviewed. You can assign the PR to them by writing /assign @vincent-pli in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Sep 08 '22 12:09 tekton-robot

Hi @Aldiuser. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Sep 08 '22 12:09 tekton-robot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Dec 07 '22 13:12 tekton-robot

@Aldiuser This is not the case anymore after https://github.com/tektoncd/cli/pull/1533

Moreover, the same feature handling in the operator has been done with #1025

piyush-garg avatar Dec 29 '22 05:12 piyush-garg

@Aldiuser: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Dec 29 '22 05:12 tekton-robot

/close as this is not the current scenario

piyush-garg avatar Jan 12 '23 09:01 piyush-garg