[pipelines-in-pipelines] Support cancellation for pipelines-in-pipelines

[sallyyama]

Changes

The Pipelines-in-Pipelines is provided by a controller that implements the Custom Task interface. Currently, the cancellation is not implemented for the customRun so when the main pipelineRun is cancelled, the pipelineRuns spawned by the customRuns won't be cancelled accordingly, which can lead to confusion.

This PR addresses the above issue, by cancelling the spawned pipelineRuns when the corresponding customRuns are marked as Cancelled.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

• [x] Includes docs (if user facing)
• [x] Commit messages follow commit message best practices
• [x] Commit messages includes a project tag in the subject - e.g. [OCI], [hub], [results], [task-loops]

See the contribution guide for more details.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: sallyyama (6f0ffa9814c7d143e3cf2879876fb460f0126bda)

[tekton-robot]

Hi @sallyyama. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chmouel]

/ok-to-test

[sallyyama]

/retest

[sallyyama]

/retest

[sallyyama]

Hi @chmouel, would you please help review it? Thanks.

[sallyyama]

/assign @chmouel

[chmouel]

sorry but I don't know very much this code to be able to be helpful with this

[sallyyama]

/unassign @chmouel

[sallyyama]

/assign @afrittoli

[sallyyama]

@afrittoli Would you please help review it? Thanks a lot.

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from afrittoli after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pipelines-in-pipelines/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[sallyyama]

@afrittoli @imjasonh @bobcatfish @vdemeester This is a minor change. Would you please help review? Thanks a lot.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~pipelines-in-pipelines/OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[sallyyama]

Hello @vdemeester, sorry it was not mergeable because PR can't be rebased. So I did a rebase just now. Would you please help approve again? Thanks a lot!

[vdemeester]

/lgtm

[sallyyama]

/lgtm

Thanks @vdemeester for your quick response.