experimental
experimental copied to clipboard
tektoncd
Presubmits silently skipped if project does not have a presubmit-tests.sh file
Our docs instruct users to add their project to the list of tests to run presubmits for, but don't instruct them to add a presubmit-tests.sh file. If the project does not have one, presubmits pass with no indication that tests are not actually being run. Example log message
===================
==== WORKFLOWS ====
===================
workflows/README.md is modified so testing project workflows
/home/prow/go/src/github.com/tektoncd/experimental/workflows /home/prow/go/src/github.com/tektoncd/experimental
Skip due to no './test/presubmit-tests.sh' file
from https://storage.googleapis.com/tekton-prow/pr-logs/pull/tektoncd_experimental/910/pull-tekton-experimental-unit-tests/1579880360286621696/build-log.txt
It's easy enough to update the docs but we should also fail presubmits if there's a project in the list of projects to run presubmits for that doesn't actually have presubmits set up.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle stale
Send feedback to tektoncd/plumbing.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle rotten
Send feedback to tektoncd/plumbing.
@lbernick @vdemeester maybe we could allow for non-failure through an environment variable set in the job definition, so that if someone wants the job to pass without a presubmit they must explicitly set the variable and be aware of what they are doing.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle stale
Send feedback to tektoncd/plumbing.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle rotten
Send feedback to tektoncd/plumbing.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/close
Send feedback to tektoncd/plumbing.
@tekton-robot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopenwith a justification. Mark the issue as fresh with/remove-lifecycle rottenwith a justification. If this issue should be exempted, mark the issue as frozen with/lifecycle frozenwith a justification./close
Send feedback to tektoncd/plumbing.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.