dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

chore: golang update

Open hawksight opened this issue 3 months ago • 3 comments

/kind misc

Changes

Updating golang version as it should address all of the CVE's that can be seen from trivy run against the latest release, v0.61.0.

Unsure if this is right / enough to update the go version for this project, but hoping the CI will be enough.

Ran the following locally before opening PR:

go mod tidy
go mod verify

Not other changes seemed to happen

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [X] Docs included if any changes are user facing
  • [X] Tests included if any functionality added or changed
  • [ ] Follows the commit message standard
  • [X] Meets the Tekton contributor standards (including functionality, content, code)
  • [X] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [X] Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

hawksight avatar Sep 19 '25 16:09 hawksight

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign briangleeson after the PR has been reviewed. You can assign the PR to them by writing /assign @briangleeson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Sep 19 '25 16:09 tekton-robot

CLA Not Signed

Thanks for the PR @hawksight. This doesn't actually update the version used to build the release though. That would require updating the ko-gcloud image (which is shared by multiple Tekton projects), then updating the Dashboard's release pipeline to use the new version.

As far as I can see running trivy locally against the latest release image, the Dashboard isn't impacted by any of the 6 CVEs currently reported. It either does not use the stdlib functions referenced, or does not use them in a way that's impacted by the reported vulnerabilities. Trivy's reporting often produces false positives due to the limitation documented at https://github.com/aquasecurity/trivy/blob/main/docs/docs/coverage/language/golang.md#stdlib-vulnerabilities

That said, there's no harm in updating anyway.

The version in go.mod here is updated by dependabot as needed based on minimum version required by dependencies.

AlanGreene avatar Sep 19 '25 18:09 AlanGreene