dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

new runMetadata header

Open LyndseyBu opened this issue 7 months ago • 1 comments

Changes

First draft PR for new pipelineRun details page header - runMetadata

  • new layout for the Run Header
  • labels visible in the run header are clickable to filter pipeline runs/task runs
  • trigger information displayed when available image

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [ ] Docs included if any changes are user facing
  • [ ] Tests included if any functionality added or changed
  • [ ] Follows the commit message standard
  • [ ] Meets the Tekton contributor standards (including functionality, content, code)
  • [ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [ ] Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

LyndseyBu avatar May 30 '25 11:05 LyndseyBu

Slight containment issue with the popover: image

AlanGreene avatar Jul 07 '25 12:07 AlanGreene

Clicking outside the overflow popover or pressing escape should dismiss it. It should probably also capture tab focus to prevent focusing on elements behind it.

Closing the modal should return focus to the overflow button in the popover.

AlanGreene avatar Jul 07 '25 12:07 AlanGreene

Slight containment issue with the popover

I've not been able to reproduce this one yet image

LyndseyBu avatar Jul 10 '25 10:07 LyndseyBu

I've not been able to reproduce this one yet

Looks like it requires the last displayed label to be longer / truncated, which forces the +n to the next line

You can use the 'Import resources' feature to reproduce a run similar to the one I encountered it on. Use the inputs from the Dashboard tutorial: https://tekton.dev/docs/dashboard/tutorial/#import-some-tekton-resources-using-the-tekton-dashboard

Ignore the rest of the setup, it doesn't matter if the run actually succeeds, just that it's created.

AlanGreene avatar Jul 10 '25 13:07 AlanGreene

minor visual issue with a narrower window: image

it could do with some space between the status and the actions menu button, 1 rem should be enough

The rest is looking great! 👍

AlanGreene avatar Jul 15 '25 14:07 AlanGreene

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jul 15 '25 15:07 tekton-robot

/kind feature

AlanGreene avatar Jul 15 '25 17:07 AlanGreene