dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Skipped tasks shown as pending

Open larhauga opened this issue 3 years ago • 5 comments

Describe the bug

Pipelines with tasks that are skipped (like due to non master branch run) is observed to have the state of pending even though it has been skipped. This issue came to us from end-users, which did not understand why the task was still pending.

image

Expected behaviour

We expect the status of the skipped task to be Skipped; not Pending.

Steps to reproduce the bug

In this case we have a when condition, that skipps this task if branch is main or master.

...
    - name: promote
      runAfter:
      - mvn-build
      taskRef:
        kind: ClusterTask
        name: # taskname
      when:
      - input: $(params.gitbranchname)
        operator: in
        values:
        - master
        - main
...

Environment details

  • Kubernetes Platform: EKS
  • Kubernetes or OpenShift version: 1.21
  • Install mode (if on OpenShift): no
  • Cloud-provider/provisioner: EKS
  • Versions:
    • Tekton Dashboard: 0.23.0
    • Tekton Pipelines: 0.31.0
    • Tekton Triggers: 0.18.0
  • Install namespaces:
    • Tekton Dashboard: tekton-pipelines
    • Tekton Pipelines:
    • Tekton Triggers:

Additional Info

larhauga avatar Jan 21 '22 07:01 larhauga

Thanks for raising this issue @larhauga. We're currently considering a redesign of this page to improve display of a number of things including when expressions, retries, and more.

AlanGreene avatar Jan 22 '22 14:01 AlanGreene

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Apr 23 '22 13:04 tekton-robot

This is something we'll be addressing as part of the PipelineRun details page redesign which is currently in progress. Freezing so it doesn't get auto closed.

/lifecycle frozen

AlanGreene avatar Apr 23 '22 13:04 AlanGreene

When we address this we should review https://github.com/tektoncd/pipeline/pull/4829 and TEP-0103. This makes additional useful information available regarding the reason for a task being skipped.

AlanGreene avatar May 09 '22 16:05 AlanGreene

Hoping to revisit this soon. Related to https://github.com/tektoncd/dashboard/issues/1445

AlanGreene avatar Feb 10 '23 17:02 AlanGreene