dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Add support for array parameters in the Create TaskRun and Create PipelineRun pages

Open torrescd opened this issue 4 years ago • 6 comments

Is your feature request related to a problem ?

Imposible to enter/change an array parameter through UI.

All input changes seems to be transformed to string. (Default untouched arrays work well)

Describe the solution you'd like

Some way to enter/change an array parameter

Describe alternatives you've considered

Additional context

Steps to see current behaviour (array parameters converted to string)

  • Task with array parameter
  • Change default value
  • Create taskrun

torrescd avatar Aug 13 '21 13:08 torrescd

Thanks for opening this issue @torrescd. I'm converting it to a feature request since it's not something we've supported in any Dashboard release so far but would be a good addition.

There are a number of ways we could present this in the Create PipelineRun / TaskRun UI. Some initial thoughts:

  1. a simple textarea where each array item is entered on a separate line
  2. similar to the labels / node selector fields where we present a list of text inputs and buttons to add / remove them as needed
  3. something else?

Do you have any thoughts on how you would expect to be able to enter them?

Can you provide some examples of how you're using array parameters in your Tasks?

AlanGreene avatar Aug 13 '21 18:08 AlanGreene

Thank you for consider the request.

Maybe another possibility to process the array value always as a yaml array, able to be parsed. e.g.

["value","anotherValue"]

- a
- b

[] null empty?

Currently, when the default value is displayed is showing a comma-separated list, but is not able to be parsed if you enter a new list, maybe this list format working is another option.

Regards!

torrescd avatar Aug 13 '21 20:08 torrescd

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Nov 11 '21 21:11 tekton-robot

We still want this, freezing so it doesn't get auto-closed. /lifecycle frozen

AlanGreene avatar Nov 12 '21 11:11 AlanGreene

This is currently supported on the Create PipelineRun page via the recently added YAML mode. Create TaskRun will get the same treatment in the near future.

It would still be great to have this functionality in the form-based UI too for ease of use so keeping the issue open.

AlanGreene avatar Feb 10 '23 17:02 AlanGreene

/area roadmap

AlanGreene avatar Feb 15 '23 15:02 AlanGreene