community icon indicating copy to clipboard operation
community copied to clipboard

[TEP-0048] Task Results without Results

Open vinamra28 opened this issue 3 years ago • 14 comments

This TEP is updated with the new proposed solution where we now specify the default value for results at the time where they are consumed.

/kind feature

Signed-off-by: vinamra28 [email protected]

vinamra28 avatar Feb 13 '23 16:02 vinamra28

/kind tep

vinamra28 avatar Feb 13 '23 16:02 vinamra28

Before: default results at the authoring time Now: default results at the time of resolution

pritidesai avatar Feb 13 '23 17:02 pritidesai

API WG - is confusing in the first review, default in a pipelineTask instead of task authoring time Alternative 1 - instead of default value during the resolution, specify default explicitly.

/assign @afrittoli /assign @lbernick

pritidesai avatar Feb 13 '23 17:02 pritidesai

noting that this was first suggested and discussed in https://github.com/tektoncd/community/pull/240#discussion_r512128199 by @bobcatfish and @chhsia0

a user @kyubisation - also asked for this feature - https://github.com/tektoncd/pipeline/issues/6139#issuecomment-1424677912

jerop avatar Feb 13 '23 17:02 jerop

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from afrittoli after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Feb 15 '23 13:02 tekton-robot

/assign

Yongxuanzhang avatar Feb 15 '23 20:02 Yongxuanzhang

The following Tekton test failed:

Test name Commit Details Required Rerun command
pull-community-teps-lint f76fefe784c552b61523a40bd54779e0c346fee8 link true /test pull-community-teps-lint

tekton-robot avatar Feb 19 '23 03:02 tekton-robot

@vinamra28: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Mar 30 '23 16:03 tekton-robot

API WG - @jerop to check with @vinamra28

pritidesai avatar May 15 '23 16:05 pritidesai

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 13 '23 16:08 tekton-robot

/remove-lifecycle stale apologies for leaving this in between 😅 , will take this up and try to get this done

vinamra28 avatar Aug 19 '23 17:08 vinamra28

API WG: @vinamra28 any updates on this?

chitrangpatel avatar Mar 04 '24 17:03 chitrangpatel

API WG: Any new updates here @vinamra28?

chitrangpatel avatar May 13 '24 16:05 chitrangpatel

Any updates on this? This proposal has existed for long and the default result feature is necessary for our pipelines

jameshwc avatar Oct 02 '24 15:10 jameshwc