community icon indicating copy to clipboard operation
community copied to clipboard

[TEP-00124] Add design and implementation details

Open kmjayadeep opened this issue 2 years ago • 1 comments

Signed-off-by: Jayadeep KM [email protected]

This PR changes the status of the TEP to implementable by adding more design details and completing the missing sections of the proposal.

kmjayadeep avatar Oct 16 '22 08:10 kmjayadeep

/uncc @wlynch @vtereso /cc @vdemeester @pxp928 from #839

wlynch avatar Oct 18 '22 17:10 wlynch

/cc @vdemeester @pxp928

wlynch avatar Oct 18 '22 17:10 wlynch

@wlynch: GitHub didn't allow me to request PR reviews from the following users: pxp928.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vdemeester @pxp928

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Oct 18 '22 17:10 tekton-robot

/kind tep

jerop avatar Oct 24 '22 15:10 jerop

/approve

afrittoli avatar Oct 25 '22 10:10 afrittoli

/assign @vdemeester @pxp928

lbernick avatar Oct 31 '22 16:10 lbernick

@lbernick: GitHub didn't allow me to assign the following users: pxp928.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @vdemeester @pxp928

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Oct 31 '22 16:10 tekton-robot

FYI @abayer @dibyom since you reviewed the design PR 🙏

afrittoli avatar Nov 03 '22 21:11 afrittoli

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, pxp928, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Nov 07 '22 12:11 tekton-robot

This has three approvals, so it should be ready for an lgtm - we can do it during the API WG today

afrittoli avatar Nov 07 '22 12:11 afrittoli

/lgtm

dibyom avatar Nov 07 '22 17:11 dibyom