[TEP-0091]Update TEP with design evaluations

[Yongxuanzhang]

This commit adds more details of design evaluation. Since we need to pull in sigstore and cosign to make this proposal work, this needs to be included in this TEP.

[lbernick]

/kind tep

[dibyom]

/assign @jerop

[afrittoli]

/assign @afrittoli

[afrittoli]

/test pull-community-teps-lint

[tekton-robot]

@afrittoli: No presubmit jobs available for tektoncd/community@main

In response to this:

/test pull-community-teps-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Yongxuanzhang]

/assign @wlynch @jagathprakash

[tekton-robot]

@Yongxuanzhang: GitHub didn't allow me to assign the following users: jagathprakash.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @wlynch @jagathprakash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Yongxuanzhang]

Thank you for the updates! It's not 100% clear to me what the proposed approach is for resource mutations. In-cluster resources today rely on a defaulting webhook and an API conversion webhook. Is the proposal here to remove both webhooks and move the defaulting and conversion logic to be executed at reconcile time, after the verification?

Hi @afrittoli, for in-cluster resources we don't propose to remove the webhooks, instead we could rely on the feature flag to skip the mutating webhooks when this feature is enabled. And in reconciler we already have called the setdefaults to make sure the default values.

[jerop]

my approval was for documenting the design evaluation that I'd requested when I saw that sigstore was pulled in in https://github.com/tektoncd/pipeline/pull/5552

now that some api changes have been added and I didn't review the previous pull requests related to this TEP, I'm removing my approval until I get a chance to review the TEP and understand the change in that context

/approve cancel

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~teps/OWNERS~~ [wlynch]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

Thanks for the discussion around the sigstore dependency, I'm happy with the decision to use the libraries and if we want to introduce direct integrations with sigstore services in Tekton Pipelines we can discuss that further down the road.

/approve

[tekton-robot]

@jagathprakash: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pritidesai]

@afrittoli please take another look, thanks!

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, bobcatfish, wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~teps/OWNERS~~ [afrittoli,bobcatfish,wlynch]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

Looks like all assigned reviewers have approved, thanks everyone!

/lgtm