community icon indicating copy to clipboard operation
community copied to clipboard

[TEP Process] Add "Collaborators" option

Open lbernick opened this issue 2 years ago • 4 comments

This commit adds the ability to specify "collaborators" for a TEP. The intention of this commit is to recognize the efforts of contributors who take the time to review and understand a proposed design, or contributors who may have worked on part of the design but are not owners of the entire design.

lbernick avatar Jun 13 '22 13:06 lbernick

do we want to add a "reviewers" option too? or is reviewing considered collaborating? either way, the incremental improvements are great!

/approve

hold until other governing board members approve changes to TEP processes /hold

cc @priyawadhwa @vdemeester @afrittoli @dibyom

jerop avatar Jun 13 '22 14:06 jerop

do we want to add a "reviewers" option too?

Good question! I view a collaborator as a bit different from a reviewer, so it could make sense to have them as separate categories, although there's a lot of potential for overlap. I'm tempted to say let's stick with just collaborator for now, but I don't have a strong opinion here.

lbernick avatar Jun 13 '22 15:06 lbernick

@afrittoli @priyawadhwa please take a look

jerop avatar Jun 21 '22 16:06 jerop

/kind tep

bendory avatar Aug 24 '22 14:08 bendory

/lgtm

bendory avatar Aug 30 '22 16:08 bendory

@bendory: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 30 '22 16:08 tekton-robot

Thanks @lbernick /lgtm

afrittoli avatar Sep 05 '22 08:09 afrittoli

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, dibyom, jerop, priyawadhwa, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~teps/OWNERS~~ [afrittoli,dibyom,jerop,priyawadhwa,vdemeester]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Sep 05 '22 08:09 tekton-robot

Removing the hold since all GB members approved

afrittoli avatar Sep 05 '22 08:09 afrittoli

/hold cancel

afrittoli avatar Sep 05 '22 08:09 afrittoli