community icon indicating copy to clipboard operation
community copied to clipboard

[TEP Process] TEPs may be merged offline

Open lbernick opened this issue 3 years ago • 3 comments

This commit updates the TEP process description to state that after approval requirements have been met, no additional confirmation is required to merge the TEP, and merging does not need to occur during any meeting.

lbernick avatar Jun 13 '22 13:06 lbernick

/approve

hold until other governing board members approve changes to TEP processes /hold

cc @priyawadhwa @vdemeester @afrittoli @dibyom

jerop avatar Jun 13 '22 14:06 jerop

@afrittoli @dibyom @priyawadhwa please take a look

jerop avatar Jun 21 '22 16:06 jerop

/kind tep

bendory avatar Aug 24 '22 14:08 bendory

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, jerop, priyawadhwa, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~teps/OWNERS~~ [dibyom,jerop,priyawadhwa,vdemeester]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Aug 30 '22 16:08 tekton-robot

@pritidesai @jerop I've addressed the feedback from the discussion at today's governing board meeting. In particular, I have explained that we review TEPs at working group meetings, but that there are multiple channels for finding reviewers for TEPs and discussing them, and that a TEP may be merged once it has met our approval requirements. I have also clarified who are the "people with permissions" to perform these prow commands by linking to the appropriate sections of the contributor ladder.

@tektoncd/governing-board PTAL

lbernick avatar Aug 30 '22 18:08 lbernick

@bendory I'm going to remove the TEP label since we typically use this for reviewing TEPs, not reviewing changes to the TEP process

/test pull-community-teps-lint

lbernick avatar Aug 30 '22 18:08 lbernick

@lbernick: No presubmit jobs available for tektoncd/community@main

In response to this:

@bendory I'm going to remove the TEP label since we typically use this for reviewing TEPs, not reviewing changes to the TEP process

/test pull-community-teps-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 30 '22 18:08 tekton-robot

/remove-label tep

lbernick avatar Aug 30 '22 18:08 lbernick

@lbernick: The label(s) /remove-label tep cannot be applied. These labels are supported: ``

In response to this:

/remove-label tep

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 30 '22 18:08 tekton-robot

thanks @pritidesai I've made the suggested changes!

lbernick avatar Sep 01 '22 19:09 lbernick

thanks @lbernick 👍

/lgtm

pritidesai avatar Sep 01 '22 23:09 pritidesai

thanks Priti!

/hold cancel

lbernick avatar Sep 02 '22 14:09 lbernick