community icon indicating copy to clipboard operation
community copied to clipboard

TEP ~ Automatically manage concurrent PipelineRuns

Open williamlfish opened this issue 2 years ago • 17 comments

TEP outlining a feature that would give developers the option to have the PipelineRuns that potentially overlap an ability to only run the most recent one. Please feel free to let me know if any other information outlining the idea is needed or if I can be helpful in clarifying.

I would also love any input on what to call this? Describing the situation more succinctly would be ideal and am open to any recommendations 😅

williamlfish avatar May 27 '22 00:05 williamlfish

/assign @puneetpunamiya

williamlfish avatar May 27 '22 00:05 williamlfish

I think this has some similarities with https://hackmd.io/GK_1_6DWTvSiVHBL6umqDA (that I have yet to propose as a TEP 😅 ) /assign

vdemeester avatar May 30 '22 15:05 vdemeester

@vdemeester I like a lot if what you have in that doc! You mention using annotations/cm, and that feels a lot more flexible. This is also a feature I'm very interested in seeing progress on 😸, so in an effort to continue the conversation, and perhaps meld the TEPs into one, should we continue discussing details in that md file you posted? or is here more appropriate? Thanks!

williamlfish avatar Jun 01 '22 01:06 williamlfish

@vdemeester I like a lot if what you have in that doc! You mention using annotations/cm, and that feels a lot more flexible. This is also a feature I'm very interested in seeing progress on smile_cat, so in an effort to continue the conversation, and perhaps meld the TEPs into one, should we continue discussing details in that md file you posted? or is here more appropriate? Thanks!

Yes we should definitely merge the two into one TEP and collaborate on it. I think we can try to merge the content of this and the hackmd in the hackmd, and once we feel it's kind-of ready, we update this pull-request. How does it sound ?

(feel free to ping me on slack as well 😉 )

vdemeester avatar Jun 01 '22 08:06 vdemeester

@vdemeester sounds good to me! ima mark this as a WIP, and will begin to leave thoughts on the md

williamlfish avatar Jun 01 '22 14:06 williamlfish

/kind tep

jerop avatar Jun 06 '22 16:06 jerop

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from puneetpunamiya after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jul 29 '22 14:07 tekton-robot

@vdemeester updated! 🎈

williamlfish avatar Jul 29 '22 14:07 williamlfish

/assign @lbernick

afrittoli avatar Aug 01 '22 16:08 afrittoli

@williamlfish and I are now working together in this doc

@vdemeester sorry to create another doc to merge! this doc is going in a bit of a different direction from the hackmd so I think it is useful to have both. would love your input here

lbernick avatar Aug 09 '22 14:08 lbernick

@williamlfish: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 09 '22 17:08 tekton-robot

I think this is a pretty meaty feature and would benefit from us agreeing on the goals of this TEP before moving to the proposal. @williamlfish is on board with me opening an initial PR for the problem statement (chatted offline) so I created https://github.com/tektoncd/community/pull/791

lbernick avatar Aug 19 '22 16:08 lbernick

API WG - @lbernick to check with @williamlfish if we can close this one

pritidesai avatar Aug 29 '22 16:08 pritidesai

@pritidesai @vdemeester @lbernick im okay with this being closed. would love to be tagged in future efforts on this tho 😄

williamlfish avatar Aug 29 '22 17:08 williamlfish

thank you @williamlfish 👍

thank you @lbernick for adding @williamlfish as a TEP author. Please also add @williamlfish as a co-author to the commit and PR description:

Co-authored-by: 

pritidesai avatar Aug 30 '22 04:08 pritidesai

@pritidesai @vdemeester @lbernick im okay with this being closed. would love to be tagged in future efforts on this tho smile

@williamlfish We need to reconcile the content of this with the tep-120. So it's gonna be more that just tagged in future efforts, we'll call you 😬

vdemeester avatar Aug 30 '22 06:08 vdemeester

Please also add williamlfish as a co-author to the commit and PR description

Thanks for the reminder @pritidesai! I don't want to amend the commit history now that it's already merged, but I'll update the PR description and will add that next time on the commit message.

lbernick avatar Aug 30 '22 13:08 lbernick

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Nov 28 '22 14:11 tekton-robot