cli icon indicating copy to clipboard operation
cli copied to clipboard

Support for taskRunSpecs Property of a PipelineRun with tkn pipeline start

Open danielhelfand opened this issue 5 years ago • 24 comments

Expected Behavior

Related: https://github.com/tektoncd/pipeline/issues/2362 https://github.com/tektoncd/pipeline/pull/2389

Pipelines is adding support for allowing TaskRun properties to be defined for TaskRuns that are part of a PipelineRun. As of the current state of https://github.com/tektoncd/pipeline/pull/2389, this will occur via a taskRunSpecs property that is part of a PipelineRun spec.

tkn should support an option to allow a user to specify a taskRunSpec via tkn pipeline start that will allow a user more control over how TaskRuns part of a PipelineRun should be executed.

My initial thought would be to allow a user to define their taskRunSpecs property in a file and then tkn would accept this file via an option:

tkn pipeline start pipelineName --taskrunspec taskrunspec.yaml

tkn pipeline start pipelineName --taskrunspec https://www.github.com/repo/user/taskrunspec.yaml

After parsing the file, tkn would add this property to the PipelineRun.

Open to other options on what the best way to supply this information would be, but, due to how much can be defined for a TaskRun spec, it may be best to allow this information to be stored in file format.

Additional Info

This feature is not currently available in pipelines, so this issue will depend on the final state of #2389 and whenever tkn can update its pipeline dependency with #2389.

danielhelfand avatar Apr 30 '20 13:04 danielhelfand

Discussed in working group on 5/12/20. Will look into using kustomize here to help with taskRunSpec support. The pr has been merged and we'll need to wait for a pipelines release with this feature included to start development.

danielhelfand avatar May 12 '20 14:05 danielhelfand

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 14 '20 08:08 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 14 '20 08:08 tekton-robot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 14 '20 08:08 tekton-robot

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 14 '20 08:08 tekton-robot

/reopen /remove-lifecycle rotten /remove-lifecycle stale

vdemeester avatar Aug 14 '20 09:08 vdemeester

@vdemeester: Reopened this issue.

In response to this:

/reopen /remove-lifecycle rotten /remove-lifecycle stale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 14 '20 09:08 tekton-robot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Nov 12 '20 10:11 tekton-robot

/remove-lifecycle stale

vdemeester avatar Nov 12 '20 11:11 vdemeester

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Feb 10 '21 12:02 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Mar 12 '21 13:03 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar May 07 '21 19:05 tekton-robot

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar May 07 '21 19:05 tekton-robot

/reopen /remove-lifecycle rotten

vinamra28 avatar Mar 31 '23 02:03 vinamra28

@vinamra28: Reopened this issue.

In response to this:

/reopen /remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Mar 31 '23 02:03 tekton-robot

assign @haedaal

piyush-garg avatar Mar 31 '23 12:03 piyush-garg

/assign @haedaal

piyush-garg avatar Mar 31 '23 12:03 piyush-garg

@piyush-garg: GitHub didn't allow me to assign the following users: haedaal.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @haedaal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Mar 31 '23 12:03 tekton-robot

/assign me

haedaal avatar Apr 02 '23 03:04 haedaal

@haedaal: GitHub didn't allow me to assign the following users: me.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign me

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Apr 02 '23 03:04 tekton-robot

/assign @haedaal

piyush-garg avatar Apr 03 '23 05:04 piyush-garg

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jul 02 '23 05:07 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 01 '23 06:08 tekton-robot

/remove-lifecycle rotten /lifecycle frozen there is already a PR for this #1969

vinamra28 avatar Aug 19 '23 17:08 vinamra28