cli icon indicating copy to clipboard operation
cli copied to clipboard
verified publisher icon tektoncd

chore: referencing the setup-kind script from the plumbing repo instead of copying it

Open infernus01 opened this issue 4 months ago • 11 comments

Changes

Fixes #2520

  • Remove hack/setup-kind.sh and replaced by tektoncd/plumbing version

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Includes tests (if functionality changed/added)
  • [x] Run the code checkers with make check
  • [x] Regenerate the manpages, docs and go formatting with make generated
  • [x] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

infernus01 avatar Aug 14 '25 18:08 infernus01

/ok-to-test

divyansh42 avatar Aug 16 '25 18:08 divyansh42

/ok-to-test

divyansh42 avatar Aug 18 '25 04:08 divyansh42

/lgtm

pratap0007 avatar Aug 18 '25 05:08 pratap0007

/ok-to-test /retest

pratap0007 avatar Aug 18 '25 13:08 pratap0007

Did the CI run? Since we already have /ok-to-test multiple times, but I didn't see the CIs running anytime?

infernus01 avatar Aug 20 '25 13:08 infernus01

Did the CI run? Since we already have /ok-to-test multiple times, but I didn't see the CIs running anytime?

It seems there is some issue, can you try to rebase the PR?

divyansh42 avatar Aug 20 '25 14:08 divyansh42

@infernus01 can you rebase ?

vdemeester avatar Oct 15 '25 08:10 vdemeester

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from pratap0007 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Oct 22 '25 12:10 tekton-robot

/lgtm

pratap0007 avatar Oct 23 '25 08:10 pratap0007

@infernus01: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Oct 28 '25 00:10 tekton-robot

@infernus01 can you please rebase it?

pratap0007 avatar Nov 03 '25 13:11 pratap0007