cli
cli copied to clipboard
tektoncd
pipeline start supports taskRunSpec argument
Changes
Add taskRunSpec argument on tkn pipeline start
closes https://github.com/tektoncd/cli/issues/951
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
- [x] Includes tests (if functionality changed/added)
- [ ] Run the code checkers with
make check - [x] Regenerate the manpages, docs and go formatting with
make generated - [ ] Commit messages follow commit message best practices
See the contribution guide for more details.
Release Notes
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign vdemeester after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: haedaal / name: Minjae Kim (feb0a01be36d9c2930ce232740657d25e4d6604f, bbe97402351d594c2654b278825d5cb801a1c650, 1e5023fe5a632e7580817373619cede226ac23ba, aabe9e68d2834d25722f5a1a70d3a9a156b33018, 095983aae9f4628a0d83ce97911f4a18dfd89175, 4dba6adae73076156894cd6fbe3a04136bb22e6d)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @haedaal. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle stale
Send feedback to tektoncd/plumbing.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle rotten
Send feedback to tektoncd/plumbing.
@haedaal
Would love to get this in, can you please squash the commit into one, with nice commit msg.
@haedaal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-tekton-cli-unit-tests | 5f4ffd50bf7d7295467e2a5d3828ba2f2cfc3c4b | link | true | /test pull-tekton-cli-unit-tests |
| pull-tekton-cli-build-tests | 5f4ffd50bf7d7295467e2a5d3828ba2f2cfc3c4b | link | true | /test pull-tekton-cli-build-tests |
| pull-tekton-cli-integration-tests | 5f4ffd50bf7d7295467e2a5d3828ba2f2cfc3c4b | link | true | /test pull-tekton-cli-integration-tests |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@haedaal: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.