cli icon indicating copy to clipboard operation
cli copied to clipboard

Add timestamps flags to all pipeline resources that have logs command

Open seongpyoHong opened this issue 3 years ago • 2 comments

Changes

Related PR: https://github.com/tektoncd/cli/pull/1751 Add timestamps flags to all pipeline resources(clusterTask, Task, Pipeline, TaskRun) that have logs command.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Includes tests (if functionality changed/added)
  • [x] Run the code checkers with make check
  • [x] Regenerate the manpages, docs and go formatting with make generated
  • [x] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Add timestamps flags to all pipeline resources that have logs command.

seongpyoHong avatar Oct 16 '22 05:10 seongpyoHong

Hi @seongpyoHong. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Oct 16 '22 05:10 tekton-robot

/ok-to-test /lgtm

piyush-garg avatar Oct 18 '22 07:10 piyush-garg

/retest

piyush-garg avatar Oct 18 '22 10:10 piyush-garg

/lgtm

chmouel avatar Oct 18 '22 16:10 chmouel

/retest

seongpyoHong avatar Oct 23 '22 08:10 seongpyoHong

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Oct 24 '22 06:10 tekton-robot