cli icon indicating copy to clipboard operation
cli copied to clipboard

[TEP-0093] Add sign and verify to tektont cli

Open Yongxuanzhang opened this issue 3 years ago • 3 comments

Changes

This commit adds sign and verify as subcommands for task and pipeline. Examples:

tkn task sign examples/example-task.yaml -K=cosign.key -f=signed.yaml
tkn task verify examples/signed.yaml -K=cosign.pub

Signed-off-by: Yongxuan Zhang [email protected]

/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Includes tests (if functionality changed/added)
  • [ ] Run the code checkers with make check
  • [ ] Regenerate the manpages, docs and go formatting with make generated
  • [ ] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Yongxuanzhang avatar Oct 13 '22 20:10 Yongxuanzhang

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

tekton-robot avatar Oct 13 '22 20:10 tekton-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign pradeepitm12 after the PR has been reviewed. You can assign the PR to them by writing /assign @pradeepitm12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Oct 13 '22 20:10 tekton-robot

cc @concaf

vdemeester avatar Oct 14 '22 07:10 vdemeester

I wonder if we should "put" those commands under experimental (see https://github.com/tektoncd/cli/pull/1575). Otherwise, nice ! /approve

vdemeester avatar Nov 14 '22 10:11 vdemeester

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Nov 14 '22 10:11 tekton-robot

looks good :)

concaf avatar Nov 14 '22 10:11 concaf

I wonder if we should "put" those commands under experimental (see #1575). Otherwise, nice ! /approve

Yes that sounds good! I will put them under experimental! But should we merge that PR first?

Yongxuanzhang avatar Nov 14 '22 16:11 Yongxuanzhang

/retest

Yongxuanzhang avatar Nov 14 '22 16:11 Yongxuanzhang

I wonder if we should "put" those commands under experimental (see #1575). Otherwise, nice ! /approve

Yes that sounds good! I will put them under experimental! But should we merge that PR first?

We should probably merge #1575 first indeed 👼🏼 cc @pradeepitm12 @piyush-garg

vdemeester avatar Nov 15 '22 11:11 vdemeester

please fix typo -- "tekton", not "tektont" in the title

bendory avatar Nov 23 '22 19:11 bendory

/lgtm

piyush-garg avatar Nov 24 '22 03:11 piyush-garg