cli icon indicating copy to clipboard operation
cli copied to clipboard

Use golang 1.17.3 in contrib/tkn-image/Dockerfile

Open mattysweeps opened this issue 3 years ago • 4 comments
trafficstars

Changes

  • Bump the default GOLANG_VERSION to 1.17.3 The image was not building with the existing default value, 1.13.* due to the use of embeded files

TESTED:

docker build --file=contrib/tkn-image/Dockerfile --target=tkn --tag tkn:latest .

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Includes tests (if functionality changed/added)
  • [ ] Run the code checkers with make check
  • [ ] Regenerate the manpages, docs and go formatting with make generated
  • [ ] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

mattysweeps avatar Aug 05 '22 19:08 mattysweeps

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: mattysweeps / name: Matthew Broomfield (cf6affe4f3a6f10fc3ced3db8718e709ed1831af)

Hi @mattysweeps. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 05 '22 19:08 tekton-robot

@mattysweeps Currently the Dockerfile in this repo is not getting used, the one which is getting used is https://github.com/tektoncd/plumbing/blob/main/tekton/images/tkn/Dockerfile

piyush-garg avatar Aug 10 '22 07:08 piyush-garg

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Aug 18 '22 10:08 tekton-robot

/ok-to-test

bendory avatar Aug 19 '22 15:08 bendory

/lgtm but robot doesn't like me yet 😿

bendory avatar Aug 23 '22 12:08 bendory

@bendory: changing LGTM is restricted to collaborators

In response to this:

/lgtm but robot doesn't like me yet 😿

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 23 '22 12:08 tekton-robot

/retest-required

bendory avatar Aug 24 '22 11:08 bendory

/retest /lgtm

piyush-garg avatar Aug 24 '22 17:08 piyush-garg