cli icon indicating copy to clipboard operation
cli copied to clipboard

Remove PipelineResource support and subcommands

Open vdemeester opened this issue 3 years ago • 5 comments

/kind cleanup

PipelineResource is deprecated and is removed with the removal of v1alpha1, we need to remove it from tkn.

/assign

vdemeester avatar Jul 26 '22 11:07 vdemeester

Actually, it is still there, so it's less of a priority than I though.

vdemeester avatar Jul 26 '22 11:07 vdemeester

I was a little worried when I saw this since the Dashboard still relies on PipelineResource support for its import functionality and I thought I had missed something in the recent Pipeline release notes 😅 Looks like it was only the v1alpha1 versions of the v1beta1 resources that were removed so we're OK for now… 😌

AlanGreene avatar Jul 26 '22 11:07 AlanGreene

@AlanGreene yeah, I got confused by my own change ; long back I moved the PipelineResource go type to their own package, so when I looked this morning I was like "oh PipelineResource is gone from v1alpha1".. but ain't true 😹. It's just in a different package 🙃

vdemeester avatar Jul 26 '22 11:07 vdemeester

For the time being we can add deprecation flag/message for the pipelineresource command.

pradeepitm12 avatar Sep 06 '22 12:09 pradeepitm12

/assign @piyush-garg

pradeepitm12 avatar Sep 27 '22 12:09 pradeepitm12

We have marked them deprecated some release ago, waiting for them to be removed in pipeline, we will do the same along with that

piyush-garg avatar Jan 16 '23 07:01 piyush-garg

Thank you for taking the precautions here!

Since the pipelineResources are going to be removed in pipeline v0.45 as designed in TEP074 and according to deprecation.md, (some have already been removed eg. cloudevent and cluster PipelineResources in v0.44), I think we might update the tag as important soon?

JeromeJu avatar Jan 31 '23 14:01 JeromeJu

/assign @pratap0007

piyush-garg avatar Apr 13 '23 05:04 piyush-garg

@piyush-garg: GitHub didn't allow me to assign the following users: pratap0007.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @pratap0007

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Apr 13 '23 05:04 tekton-robot

/assign

pratap0007 avatar Apr 13 '23 05:04 pratap0007

it is done in the main branch and will be available with 0.31 release

piyush-garg avatar May 09 '23 11:05 piyush-garg