cli icon indicating copy to clipboard operation
cli copied to clipboard

Try plugins from where tkn binary is

Open chmouel opened this issue 3 years ago • 5 comments

Try the plugin where tkn binary is :

i.e: you uncompress a tarball or install tkn-foo and tkn in ~/Downloads/ and run

~/Downloads/tkn foo

it would work even if ~/Downloads is not in path.

Signed-off-by: Chmouel Boudjnah [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Includes tests (if functionality changed/added)
  • [ ] Run the code checkers with make check
  • [ ] Regenerate the manpages, docs and go formatting with make generated
  • [ ] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

chmouel avatar Jul 26 '22 07:07 chmouel

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from chmouel after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jul 26 '22 07:07 tekton-robot

@chmouel any example of existing command-line doing/supporting that ?

vdemeester avatar Jul 26 '22 08:07 vdemeester

@vdemeester why would you need a prior example? (ie: it does answer a use case as described in pr)

I removed the getting plugins from cwd, i wasn't convinved by it either

chmouel avatar Jul 26 '22 08:07 chmouel

/retest

chmouel avatar Jul 26 '22 11:07 chmouel

@chmouel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-cli-integration-tests dbe5f730685b5cc8a7ed74dabea702cd238daa80 link true /test pull-tekton-cli-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tekton-robot avatar Jul 26 '22 11:07 tekton-robot

let's park this, I am not so sure if it's that useful

chmouel avatar Sep 22 '22 10:09 chmouel