cli icon indicating copy to clipboard operation
cli copied to clipboard

Add EventListener port-forward command

Open chenbh opened this issue 4 years ago • 18 comments

closes #1406

Changes

It figures out the pod name by using the label selectors from the deployment, which is in turn figured out from the generated name of the event listener. The default port used is the same as the one in the triggers repo, but can be overwritten in same format as docker/kubectl.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [x] Includes tests (if functionality changed/added)
  • [x] Run the code checkers with make check
  • [x] Regenerate the manpages, docs and go formatting with make generated
  • [x] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

A single port from an EventListener can be forwarded by `tkn eventlistener port-forward my-listener -n namespace --port 8080`. The default port is 8080.

chenbh avatar Sep 29 '21 16:09 chenbh

Hi @chenbh. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Sep 29 '21 16:09 tekton-robot

/ok-to-test

vinamra28 avatar Sep 30 '21 01:09 vinamra28

The following is the coverage report on the affected files. Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/eventlistener/portforward.go Do not exist 32.4%
pkg/eventlistener/eventlistener.go 72.0% 75.7% 3.7

tekton-robot avatar Oct 04 '21 15:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/eventlistener/portforward.go Do not exist 32.4%
pkg/eventlistener/eventlistener.go 72.0% 75.7% 3.7

tekton-robot avatar Oct 04 '21 18:10 tekton-robot

Hi @vinamra28, is there anything else I should do to get this PR moving?

chenbh avatar Oct 18 '21 15:10 chenbh

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jan 16 '22 15:01 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/eventlistener/portforward.go Do not exist 32.4%
pkg/eventlistener/eventlistener.go 72.0% 75.7% 3.7

tekton-robot avatar Feb 08 '22 16:02 tekton-robot

/remove-lifecycle stale

piyush-garg avatar Feb 28 '22 13:02 piyush-garg

The following is the coverage report on the affected files. Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/eventlistener/portforward.go Do not exist 32.4%
pkg/eventlistener/eventlistener.go 72.0% 75.7% 3.7

tekton-robot avatar Mar 18 '22 19:03 tekton-robot

/assign @chmouel

chenbh avatar Mar 18 '22 19:03 chenbh

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jun 23 '22 17:06 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 01 '22 00:08 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 31 '22 00:08 tekton-robot

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 31 '22 00:08 tekton-robot

/remove-lifecycle rotten

piyush-garg avatar Sep 28 '22 13:09 piyush-garg

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from chmouel after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Sep 28 '22 13:09 tekton-robot

@chenbh can you please rebase this

piyush-garg avatar Sep 28 '22 13:09 piyush-garg

@chenbh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-cli-build-tests 6ff5a6f861299f63f3724c7be878bf46d0e22e79 link true /test pull-tekton-cli-build-tests
pull-tekton-cli-integration-tests 6ff5a6f861299f63f3724c7be878bf46d0e22e79 link true /test pull-tekton-cli-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tekton-robot avatar Oct 18 '22 21:10 tekton-robot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jan 16 '23 22:01 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Feb 15 '23 22:02 tekton-robot

@chenbh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Feb 27 '23 17:02 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Mar 29 '23 17:03 tekton-robot

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Mar 29 '23 17:03 tekton-robot

@chenbh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-cli-build-tests 6ff5a6f861299f63f3724c7be878bf46d0e22e79 link true /test pull-tekton-cli-build-tests
pull-tekton-cli-build-cross-tests 6ff5a6f861299f63f3724c7be878bf46d0e22e79 link true /test pull-tekton-cli-build-cross-tests
pull-tekton-cli-integration-tests 6ff5a6f861299f63f3724c7be878bf46d0e22e79 link true /test pull-tekton-cli-integration-tests
pull-tekton-cli-unit-tests 6ff5a6f861299f63f3724c7be878bf46d0e22e79 link true /test pull-tekton-cli-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tekton-robot avatar Mar 30 '23 03:03 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Apr 29 '23 04:04 tekton-robot

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Apr 29 '23 04:04 tekton-robot